You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/11/06 19:24:44 UTC

[GitHub] [iceberg] samarthjain commented on a change in pull request #1736: [Parquet] Fix vectorized reads for negative decimals

samarthjain commented on a change in pull request #1736:
URL: https://github.com/apache/iceberg/pull/1736#discussion_r518957217



##########
File path: api/src/test/java/org/apache/iceberg/util/RandomUtil.java
##########
@@ -31,6 +31,12 @@
   private RandomUtil() {
   }
 
+  private static final Random NEGATIVE_VALUES = new Random();

Review comment:
       For some reason, TestLocalScan#testRandomData() fails if I use the random passed in to do
   ```
   boolean negate = random.nextInt(2) == 1
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org