You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/07/31 16:42:34 UTC
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11089
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
[Java] Minor fixes to the Scalafmt changes
- Fixed the Maven plugin usage
- Adds a comment about the UTF8 encoding
- Adjusted the format file layout
- Added a few rewrite rules
- Fixed files that weren’t formatted
Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
---
M java/.scalafmt.conf
M java/gradle.properties
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/pom.xml
23 files changed, 647 insertions(+), 304 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/11089/1
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Tony Foerster (Code Review)" <ge...@cloudera.org>.
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 18:29:03 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 2:
Updated because for some reason the build didn't kick.
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 20:25:00 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 3: Verified+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf
File java/.scalafmt.conf:
http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf@10
PS2, Line 10: 10
> Why not 100 cols like the rest of the Kudu code base? per https://kudu.apac
Done
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@149
PS2, Line 149: Objects.equal(before.isNullable, after.isNullable) &&
> Why not indent this?
Not sure. I think we can look at this as a follow up.
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 21:37:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 2:
(2 comments)
LGTM, just a couple small questions
http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf
File java/.scalafmt.conf:
http://gerrit.cloudera.org:8080/#/c/11089/2/java/.scalafmt.conf@10
PS2, Line 10: 80
Why not 100 cols like the rest of the Kudu code base? per https://kudu.apache.org/docs/contributing.html#_line_length
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@149
PS2, Line 149: Objects.equal(before.getType, after.getType) &&
Why not indent this?
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 20:51:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Tony Foerster (Code Review)" <ge...@cloudera.org>.
Tony Foerster has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 3: Code-Review+1
+1 on max columns 100, can't believe I missed that.
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 21:37:06 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tony Foerster, Mike Percy,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11089
to look at the new patch set (#2).
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
[Java] Minor fixes to the Scalafmt changes
- Fixed the Maven plugin usage
- Added a comment about the UTF8 encoding
- Adjusted the format file layout
- Added a few rewrite rules
- Fixed files that weren’t formatted
Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
---
M java/.scalafmt.conf
M java/gradle.properties
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/pom.xml
23 files changed, 647 insertions(+), 304 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/11089/2
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Tony Foerster, Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11089
to look at the new patch set (#3).
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
[Java] Minor fixes to the Scalafmt changes
- Fixed the Maven plugin usage
- Added a comment about the UTF8 encoding
- Adjusted the format file layout
- Added a few rewrite rules
- Bumped maxColumn to 100
- Fixed files that weren’t formatted
Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
---
M java/.scalafmt.conf
M java/gradle.properties
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/pom.xml
23 files changed, 653 insertions(+), 467 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/11089/3
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
[Java] Minor fixes to the Scalafmt changes
- Fixed the Maven plugin usage
- Added a comment about the UTF8 encoding
- Adjusted the format file layout
- Added a few rewrite rules
- Bumped maxColumn to 100
- Fixed files that weren’t formatted
Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Reviewed-on: http://gerrit.cloudera.org:8080/11089
Reviewed-by: Mike Percy <mp...@apache.org>
Reviewed-by: Tony Foerster <an...@gmail.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/.scalafmt.conf
M java/gradle.properties
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackup.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestoreOptions.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/TableMetadata.scala
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
M java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/IntegrationTestBigLinkedList.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala
M java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/TestImportExportFiles.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduRDD.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/OperationType.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/SparkUtil.scala
M java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduContextTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/KuduTestSuite.scala
M java/pom.xml
23 files changed, 653 insertions(+), 467 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Tony Foerster: Looks good to me, but someone else must approve
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
[kudu-CR] [Java] Minor fixes to the Scalafmt changes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11089 )
Change subject: [Java] Minor fixes to the Scalafmt changes
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala:
http://gerrit.cloudera.org:8080/#/c/11089/2/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@149
PS2, Line 149: Objects.equal(before.isNullable, after.isNullable) &&
> Why not indent this?
According to the docs for the corresponding scalafmt setting for this, this is the context: https://github.com/scala-js/scala-js/blob/master/CODINGSTYLE.md#long-expressions-with-binary-operators
I guess this is reasonable.
--
To view, visit http://gerrit.cloudera.org:8080/11089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied557d2ab501f43288e7edae2874ba123ab036bc
Gerrit-Change-Number: 11089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tony Foerster <an...@gmail.com>
Gerrit-Comment-Date: Tue, 31 Jul 2018 21:30:41 +0000
Gerrit-HasComments: Yes