You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/09 10:41:10 UTC
[GitHub] [skywalking] AmjadHussainSyed opened a new issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
AmjadHussainSyed opened a new issue #6919:
URL: https://github.com/apache/skywalking/issues/6919
Please answer these questions before submitting your issue.
Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [x] Feature or performance improvement
___
### Question
- What do you want to know?
I was trying to add index_name which are created in elasticsearch, I couldn't find so i edited the `chart/skywalking/templates/es-init.job.yaml` and added the following environment variable.
```
- name: SW_NAMESPACE
value: "{{ .Release.Namespace }}"
```
Please correct me if there's any other way to pass the same configuration.
___
### Bug
- Which version of SkyWalking, OS, and JRE?
8.5.0
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
followed this link to deploy https://github.com/apache/skywalking-kubernetes
release namespace is not used as a default name for elasticsearch index creation
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
I edited the `chart/skywalking/templates/es-init.job.yaml` and added the following environment variable.
```
- name: SW_NAMESPACE
value: "{{ .Release.Namespace }}"
```
now I can see the indexes in elasticsearch are created with the release namespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6919:
URL: https://github.com/apache/skywalking/issues/6919#issuecomment-835782632
@kezhenxu94 make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #6919:
URL: https://github.com/apache/skywalking/issues/6919#issuecomment-835781185
@AmjadHussainSyed if you want to add namespace for the ElasticSearch indices created by SkyWalking, please use environment variable `oap.SW_NAMESPACE` to do so. For example:
```
helm install skywalking skywalking \
# ..... other options
--set oap.env.SW_NAMESPACE=<your-namespace>
```
I personally don't think it a good idea to default `SW_NAMESPACE` to "{{ .Release.Namespace }}" in the upstream so I don't think we want to set the following in the upstream repo, @wu-sheng WDYT?
```
- name: SW_NAMESPACE
value: "{{ .Release.Namespace }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #6919:
URL: https://github.com/apache/skywalking/issues/6919#issuecomment-835781185
@AmjadHussainSyed if you want to add namespace for the ElasticSearch indices created by SkyWalking, you don't need to edit the template by hand, please use environment variable `oap.env.SW_NAMESPACE` to do so. For example:
```
helm install skywalking skywalking \
# ..... other options
--set oap.env.SW_NAMESPACE=<your-namespace>
```
I personally don't think it a good idea to default `SW_NAMESPACE` to "{{ .Release.Namespace }}" in the upstream so I don't think we want to set the following in the upstream repo, @wu-sheng WDYT?
```
- name: SW_NAMESPACE
value: "{{ .Release.Namespace }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #6919:
URL: https://github.com/apache/skywalking/issues/6919#issuecomment-835781185
@AmjadHussainSyed if you want to add namespace for the ElasticSearch indices created by SkyWalking, you don't need to edit the template by hand, please use environment variable `oap.SW_NAMESPACE` to do so. For example:
```
helm install skywalking skywalking \
# ..... other options
--set oap.env.SW_NAMESPACE=<your-namespace>
```
I personally don't think it a good idea to default `SW_NAMESPACE` to "{{ .Release.Namespace }}" in the upstream so I don't think we want to set the following in the upstream repo, @wu-sheng WDYT?
```
- name: SW_NAMESPACE
value: "{{ .Release.Namespace }}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] AmjadHussainSyed commented on issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
AmjadHussainSyed commented on issue #6919:
URL: https://github.com/apache/skywalking/issues/6919#issuecomment-835785428
@kezhenxu94 thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #6919: Allow index name (SW_NAMESPACE) for elasticsearch index name when deploying from helm charts in kubernetes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #6919:
URL: https://github.com/apache/skywalking/issues/6919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org