You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/26 20:33:18 UTC
[GitHub] [solr] jebnix opened a new pull request, #1138: Remove the Before SolrCloud section, and expand the supported feature…
jebnix opened a new pull request, #1138:
URL: https://github.com/apache/solr/pull/1138
…s section instead
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
There is a pretty confusing section that explains what existed before SolrCloud. That's pretty redundant now since this is pretty old.
# Solution
Remove the Before SolrCloud section, and expand the supported features section instead
# Tests
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-2091929874
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-2092592369
I have not reviewed the other pages related to cluster types, but trust you that this might be redundant. It's a pity that doc improvements get stalled. Feel free to land it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1138:
URL: https://github.com/apache/solr/pull/1138
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-1951346880
@jebnix Do you want to give it a final stab?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-2093362791
If you are looking for an idea... We want to rename "User Managed" to "standalone" through the ref guide ;-). And move the SolrCloud examples above the standalone examples instead of below them ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-2093356329
@jebnix thanks for this, and don't forget to ping me on any outstanding PR's you might have ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Remove the Before SolrCloud section, and expand the supported feature… [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-2092488123
> The old "User Managed" mode is still supported (https://solr.apache.org/guide/solr/latest/deployment-guide/user-managed-distributed-search.html), so I would not remove it. Guess it's there to give a reason why SolrCloud was introudced.
>
> But perhaps it should be reworded and make it clear that the feature still exists? "Before SolrCloud, solr only supported Distributed Search through (link)....."
So I am re-reading things... And we start out with a section "Solr Cluster Types" that talks about the various options. Then you get the section on "User-Managed Clusters" and then "SolrCloud Clusters". I feel like if you are this page, you don't need this content, because the differences is covered in "Solr Cluster Types", we are just derailing someone at this point... Thoughts? Does that change your mind on merging this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1138: Remove the Before SolrCloud section, and expand the supported feature…
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1138:
URL: https://github.com/apache/solr/pull/1138#issuecomment-1381859876
The old "User Managed" mode is still supported (https://solr.apache.org/guide/solr/latest/deployment-guide/user-managed-distributed-search.html), so I would not remove it. Guess it's there to give a reason why SolrCloud was introudced.
But perhaps it should be reworded and make it clear that the feature still exists? "Before SolrCloud, solr only supported Distributed Search through <User managed mode>(link)....."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org