[jira] [Commented] (ARTEMIS-4669) Clarify Large Messages around StorageManager usage

["Clebert Suconic (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823776#comment-17823776 ] 

Clebert Suconic commented on ARTEMIS-4669:
------------------------------------------

there are two methods in StorageManager that are confusing: createLargeMessage and largeMessageCreated


one is to create a core large message file and object, the other is a callback for when large messages are created (including other protocols, currently only AMQP).

These two methods should be renamed.


Also validateFile is no longer needed since we stopped storing pending records on the journal. At some point we needed to make sure the file existed before we stored records in the storage for replication. Which is no longer the case.

> Clarify Large Messages around StorageManager usage
> --------------------------------------------------
>
>                 Key: ARTEMIS-4669
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4669
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Clebert Suconic
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)