You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/01/19 02:16:12 UTC
[GitHub] [bigtop] guyuqi opened a new pull request #713: BIGTOP-3476: Fix build Oozie issues
guyuqi opened a new pull request #713:
URL: https://github.com/apache/bigtop/pull/713
Fail to build Oozie on all distros:
1. commons.lang was deprecated and need to upgrade to commons.lang3
2. For HADOOP-11356, it's needed to replace 'org.apache.hadoop.fs.permission.AccessControlException'
with 'org.apache.hadoop.security.AccessControlException'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762615783
Thanks for working on this, @guyuqi. There is discussion about dropping Oozie or not in [BIGTOP-3471](https://issues.apache.org/jira/browse/BIGTOP-3471). If you still need Oozie, you should declare needs there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762636130
@iwasakims thanks for your comments.
As posted comments on BIGTOP-3471:
if we don't foresee any opposition, let me bump oozie to 5.2.0 rather than drop it.
But before that, let's merged this Pr to fix build Oozie issues which was reported in https://ci.bigtop.apache.org/job/Bigtop-trunk-packages/678/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762642023
> Thanks for working on this, @guyuqi. There is discussion about dropping Oozie or not in [BIGTOP-3471](https://issues.apache.org/jira/browse/BIGTOP-3471). If you still need Oozie, you should declare needs there.
I'll follow up in there, thanks for the reminder! My team is an heavy user of Oozie, so we'd appreciate to have it fixed or upgraded for the next versions, even if we are planning to move away from it soon-ish in favor of Airflow. Not sure how many people still use Oozie, it could be an interesting thing to send to the users@ mailing list? (I doubt that all users are aware of BIGTOP-3471).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762667793
> The file name patch5-HADOOP-11356.diff implies that it is a diff of HADOOP-11356. Could you rename it to patch5-OOZIE-2733.diff implying the backport of OOZIE-2733.
Updated, also renamed patch4 to` patch4-OOZIE-3446.diff`, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #713:
URL: https://github.com/apache/bigtop/pull/713#discussion_r559929005
##########
File path: bigtop-packages/src/common/oozie/patch4-commons-lang3.diff
##########
@@ -0,0 +1,501 @@
+diff --git a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
+index cec634790..c5b1f091e 100644
+--- a/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
++++ b/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
+@@ -35,7 +35,7 @@ import java.util.Map;
+ import java.util.Set;
+ import java.util.StringTokenizer;
+
+-import org.apache.commons.lang.StringUtils;
++import org.apache.commons.lang3.StringUtils;
Review comment:
This was addressed by [OOZIE-3446](https://issues.apache.org/jira/browse/OOZIE-3446). Bumping Oozie to 5.2.0 could be an alternative fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762645156
@elukey
Yes, it makes sense. It's sensible that we would broadcast the definition of bom on `users@` and `dev@` mailing lists before making the decision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims merged pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
iwasakims merged pull request #713:
URL: https://github.com/apache/bigtop/pull/713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
iwasakims commented on pull request #713:
URL: https://github.com/apache/bigtop/pull/713#issuecomment-762658826
The file name patch5-HADOOP-11356.diff implies that it is a diff of HADOOP-11356. Could you rename it to patch5-OOZIE-2733.diff implying the backport of OOZIE-2733.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] iwasakims commented on a change in pull request #713: BIGTOP-3476: Fix build Oozie issues
Posted by GitBox <gi...@apache.org>.
iwasakims commented on a change in pull request #713:
URL: https://github.com/apache/bigtop/pull/713#discussion_r559926991
##########
File path: bigtop-packages/src/common/oozie/patch5-HADOOP-11356.diff
##########
@@ -0,0 +1,54 @@
+diff --git a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java b/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
+index 31d4817cb..c2233d1d8 100644
+--- a/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
++++ b/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
+@@ -45,13 +45,13 @@ import org.apache.hadoop.filecache.DistributedCache;
+ import org.apache.hadoop.fs.FileStatus;
+ import org.apache.hadoop.fs.FileSystem;
+ import org.apache.hadoop.fs.Path;
+-import org.apache.hadoop.fs.permission.AccessControlException;
Review comment:
This was fixed by [OOZIE-2733](https://issues.apache.org/jira/browse/OOZIE-2733). Upgrading Oozie should be the right fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org