Re: svn commit: r1516313 - in /poi/trunk: src/java/org/apache/poi/hssf/model/InternalWorkbook.java src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java test-data/spreadsheet/50298.xls

[Nick Burch <ap...@gagravarr.org>]

On Wed, 21 Aug 2013, centic@apache.org wrote:
> -import org.apache.poi.ddf.EscherBSERecord;
> -import org.apache.poi.ddf.EscherBoolProperty;
> -import org.apache.poi.ddf.EscherContainerRecord;
...
> -import org.apache.poi.hssf.record.BOFRecord;
> -import org.apache.poi.hssf.record.BackupRecord;
> -import org.apache.poi.hssf.record.BookBoolRecord;
....
> +import org.apache.poi.ddf.*;
> +import org.apache.poi.hssf.record.*;

I think we've generally tended to prefer explict imports to wildcard ones. 
It generally makes it easier to check where a file comes from, and avoids 
issues when we have multiple classes in different packages with the same 
name (eg Sheet)

Cheers
Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

Re: svn commit: r1516313 - in /poi/trunk: src/java/org/apache/poi/hssf/model/InternalWorkbook.java src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java test-data/spreadsheet/50298.xls

[Dominik Stadler <do...@gmx.at>]

Hi,

Ok, I will adjust the Eclipse project settings that I use, btw, any reason
why we don't have one checked in? Then we can define all formatting
settings there and anybody using Eclipse will automatically use the correct
formatting?!

Any objections to me checking in Eclipse .project/.classpath/.settings
files?

Thanks... Dominik.



On Thu, Aug 22, 2013 at 1:20 AM, Nick Burch <ap...@gagravarr.org> wrote:

> On Wed, 21 Aug 2013, centic@apache.org wrote:
>
>> -import org.apache.poi.ddf.**EscherBSERecord;
>> -import org.apache.poi.ddf.**EscherBoolProperty;
>> -import org.apache.poi.ddf.**EscherContainerRecord;
>>
> ...
>
>> -import org.apache.poi.hssf.record.**BOFRecord;
>> -import org.apache.poi.hssf.record.**BackupRecord;
>> -import org.apache.poi.hssf.record.**BookBoolRecord;
>>
> ....
>
>> +import org.apache.poi.ddf.*;
>> +import org.apache.poi.hssf.record.*;
>>
>
> I think we've generally tended to prefer explict imports to wildcard ones.
> It generally makes it easier to check where a file comes from, and avoids
> issues when we have multiple classes in different packages with the same
> name (eg Sheet)
>
> Cheers
> Nick
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>