[GitHub] [gobblin] rdsr commented on a diff in pull request #3697: [GOBBLIN-1835]Upgrade Iceberg Version from 0.11.1 to 1.2.0

["rdsr (via GitHub)" <gi...@apache.org>]

rdsr commented on code in PR #3697:
URL: https://github.com/apache/gobblin/pull/3697#discussion_r1228702119


##########
gobblin-iceberg/src/test/java/org/apache/gobblin/iceberg/writer/HiveMetadataWriterTest.java:
##########
@@ -128,7 +128,6 @@ public void clean() throws Exception {
   @BeforeSuite
   public void setUp() throws Exception {
     Class.forName("org.apache.derby.jdbc.EmbeddedDriver").newInstance();
-    startMetastore();

Review Comment:
   are we not starting the local Metastore for tests now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org