You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/26 16:03:25 UTC

[GitHub] [skywalking] yaojingguo opened a new issue #6457: Why are there two copies of CallbackAdapter.java?

yaojingguo opened a new issue #6457:
URL: https://github.com/apache/skywalking/issues/6457


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   The following two files are exactly the same:
   1. ./apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackAdapter.java
   2. ./apm-sniffer/apm-sdk-plugin/kafka-commons/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackAdapter.java
   
   ___
   ### Requirement or improvement
   Since apm-kafka-plugin artifact depends on apm-kafka-commons artifact, I think that apm-kafka-plugin's copy shoud be removed.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #6457: Why are there two copies of CallbackAdapter.java?

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6457:
URL: https://github.com/apache/skywalking/issues/6457#issuecomment-786738250


   Yes, they should share common lib.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #6457: Why are there two copies of CallbackAdapter.java?

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6457:
URL: https://github.com/apache/skywalking/issues/6457


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] zifeihan commented on issue #6457: Why are there two copies of CallbackAdapter.java?

Posted by GitBox <gi...@apache.org>.
zifeihan commented on issue #6457:
URL: https://github.com/apache/skywalking/issues/6457#issuecomment-786749446


   @yaojingguo @wu-sheng i notice too, and org.apache.skywalking.apm.plugin.kafka.CallbackAdapter is not used. @yaojingguo welcome to send pr for fix https://github.com/apache/skywalking/issues/6456 and this issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org