You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/05/04 15:34:52 UTC

[GitHub] markusthoemmes commented on a change in pull request #3609: Support "+json" content-types as WebAction input.

markusthoemmes commented on a change in pull request #3609: Support "+json" content-types as WebAction input.
URL: https://github.com/apache/incubator-openwhisk/pull/3609#discussion_r186120341
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala
 ##########
 @@ -574,7 +570,7 @@ trait WhiskWebActionsApi extends Directives with ValidateRequestSize with PostAc
         case Empty =>
           process(None, isRawHttpAction)
 
-        case HttpEntity.Strict(ContentTypes.`application/json`, json) if !isRawHttpAction =>
+        case HttpEntity.Strict(ct, json) if WhiskWebActionsApi.isJsonFamily(ct.mediaType) && !isRawHttpAction =>
 
 Review comment:
   This is for the JSON part of web-actions specifically. We **need** to check that here, since we also support FormData etc.
   
   This doesn't apply for the general API where we can do what you suggest.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services