You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/18 17:00:38 UTC

[GitHub] [beam] emilssolmanis commented on pull request #14272: [BEAM-3415] Amend TestPipeline to work with JUnit5

emilssolmanis commented on pull request #14272:
URL: https://github.com/apache/beam/pull/14272#issuecomment-802111870


   Implementing JUnit5 hooks in the existing `TestPipeline` ended up breaking compilation across tons of components, due to the now required Jupiter API, which I figured would be unacceptable for clients.
   
   I ended up opening up `TestPipeline` a bit (setting the constructor to `protected`, and some select fields), and extending it with a separate `TestPipelineJunit5` class. This way people should hopefully not get compile problems unless they use the new class.
   
   Would love to hear thoughts and iterate though, if this is not acceptable. Also happy to just collapse them back into `TestPipeline` and add the dependency to all the modules, if we think that level of breaking everyone's stuff is acceptable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org