You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2012/02/12 09:47:34 UTC

Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.


This addresses bug BOOKKEEPER-160.
    https://issues.apache.org/jira/browse/BOOKKEEPER-160


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 57a6c29 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 42f54d2 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 0c83977 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java 2e5d784 

Diff: https://reviews.apache.org/r/3874/diff


Testing
-------


Thanks,

Sijie


Re: Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

Posted by Sijie Guo <gu...@gmail.com>.

> On 2012-02-16 17:43:31, Ivan Kelly wrote:
> > In general the patch is good, but there's a few mods i'd like to see.

thanks Ivan for reviewing it. I will fix the issues as comment and attach a new patch.


> On 2012-02-16 17:43:31, Ivan Kelly wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java, line 739
> > <https://reviews.apache.org/r/3874/diff/1/?file=74506#file74506line739>
> >
> >     I don't like how EntryLogger is reaching back into Bookie to write the entries. Also, I don't think it's necessary. 
> >     
> >     How I had imagined this working is that you create a new entry log to compact into. You copy the entries across and then rename the file to the name of the old entry log.

it is not safe to do as what you described. since after compaction, the position of entries has been changed and we should let this kind of change be reflected in the index file, otherwise we would lost it. The safe way is to let the compacted entries go thru again the addEntry flow to apply the position change to index file.


> On 2012-02-16 17:43:31, Ivan Kelly wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java, line 412
> > <https://reviews.apache.org/r/3874/diff/1/?file=74507#file74507line412>
> >
> >     I think we should run compaction based purely on the watermarks. Otherwise, once we hit disk pressure, we'll have to run a lot of compaction at once.

what I am thinking is that we need to a setting to let user control whether to enable compaction or not and when to do compaction. e.g, user can configuration the threshold to the size to half of the capacity of a disk, the compaction is enabled when the capacity reaches this threshold. since compaction is expensive to move entries.


- Sijie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/#review5162
-----------------------------------------------------------


On 2012-02-12 08:47:34, Sijie Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3874/
> -----------------------------------------------------------
> 
> (Updated 2012-02-12 08:47:34)
> 
> 
> Review request for bookkeeper.
> 
> 
> Summary
> -------
> 
> bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.
> 
> 
> This addresses bug BOOKKEEPER-160.
>     https://issues.apache.org/jira/browse/BOOKKEEPER-160
> 
> 
> Diffs
> -----
> 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 57a6c29 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 42f54d2 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 0c83977 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java 2e5d784 
> 
> Diff: https://reviews.apache.org/r/3874/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sijie
> 
>


Re: Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/#review5162
-----------------------------------------------------------


In general the patch is good, but there's a few mods i'd like to see.


bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11305>

    EntryLogMeta or EntryLogMetadata would be a better name as it only refers to a single log of the entry logger.
    



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11307>

    Would it not be better to loop over entrySet rather than keySet here? 
    
    for (Map.Entry<Long, Etc> e : entryLogs2LedgersMap.entrySet()) {
    
    }



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11310>

    1024*1024 should be defined as a constant somewhere
    



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11309>

    Shouldn't you throw an exception here?



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java
<https://reviews.apache.org/r/3874/#comment11308>

    I don't like how EntryLogger is reaching back into Bookie to write the entries. Also, I don't think it's necessary. 
    
    How I had imagined this working is that you create a new entry log to compact into. You copy the entries across and then rename the file to the name of the old entry log. 



bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
<https://reviews.apache.org/r/3874/#comment11298>

    The defaults for the new options should be added to bk_server.conf in a commented out fashion like other options.
    



bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
<https://reviews.apache.org/r/3874/#comment11311>

    I think we should run compaction based purely on the watermarks. Otherwise, once we hit disk pressure, we'll have to run a lot of compaction at once.


- Ivan


On 2012-02-12 08:47:34, Sijie Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3874/
> -----------------------------------------------------------
> 
> (Updated 2012-02-12 08:47:34)
> 
> 
> Review request for bookkeeper.
> 
> 
> Summary
> -------
> 
> bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.
> 
> 
> This addresses bug BOOKKEEPER-160.
>     https://issues.apache.org/jira/browse/BOOKKEEPER-160
> 
> 
> Diffs
> -----
> 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 57a6c29 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java 42f54d2 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 0c83977 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java 2e5d784 
> 
> Diff: https://reviews.apache.org/r/3874/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sijie
> 
>


Re: Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/
-----------------------------------------------------------

(Updated 2012-03-03 08:07:49.773622)


Review request for bookkeeper.


Changes
-------

attach a new patch addressed Ivan's comment to separate minor & major compaction into different threshold and interval to make them clearly.


Summary
-------

bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.


This addresses bug BOOKKEEPER-160.
    https://issues.apache.org/jira/browse/BOOKKEEPER-160


Diffs (updated)
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 23a1ffc 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java f661e90 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java aca66e6 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 51195d4 
  bookkeeper-server/conf/bk_server.conf d005d01 

Diff: https://reviews.apache.org/r/3874/diff


Testing
-------


Thanks,

Sijie


Re: Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

Posted by Ivan Kelly <iv...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/#review5322
-----------------------------------------------------------



bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
<https://reviews.apache.org/r/3874/#comment11609>

    I like this interface. It solves the entanglement issue nicely.



bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java
<https://reviews.apache.org/r/3874/#comment11604>

    I still find the meaning of low watermark and high watermark and minor compaction and major compaction confusing. 
    
    As I understand it, a minor compaction is triggered when low watermark is hit. Major compaction is triggered when the high watermark is hit and no minor compaction ran this round. 
    
    High watermark must be lower than low watermark. So high is 0.6 for example, and low is 0.9. This is confusing, as one would expect low to be lower than high. 
    
    Also, if a minor compaction is run on low, it means (in the example above) 90% of entries in the ledger will be copied. For major, 60% will be copied. So minor compaction is heavier than major compaction, which is confusing.
    
    I think having a minor and major compaction requires that they run with different regularity, and that major compaction is heavier on the system than the minor compaction. For example, we should only run major compaction once a day, but with a threshold of 0.9, minor compaction can be run every hour with a threshold of 0.6. Both the regularity of the compactions and the threshold should be configurable and explicit. I think we should have:
     - minorCompactionInterval
     - minorCompactionThreshold
     - majorCompactionInterval
     - majorCompactionThreshold
    
    And i think some compaction should be on by default, just to make sure this stuff gets run regularly. 


- Ivan


On 2012-02-20 16:08:51, Sijie Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3874/
> -----------------------------------------------------------
> 
> (Updated 2012-02-20 16:08:51)
> 
> 
> Review request for bookkeeper.
> 
> 
> Summary
> -------
> 
> bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.
> 
> 
> This addresses bug BOOKKEEPER-160.
>     https://issues.apache.org/jira/browse/BOOKKEEPER-160
> 
> 
> Diffs
> -----
> 
>   bookkeeper-server/conf/bk_server.conf d005d01 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java d4ece94 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java aca66e6 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java PRE-CREATION 
>   bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 6bbe943 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
>   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java f661e90 
> 
> Diff: https://reviews.apache.org/r/3874/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sijie
> 
>


Re: Review Request: BOOKKEEPER-160: bookie server needs to do compaction over entry log files to reclaim disk space

Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3874/
-----------------------------------------------------------

(Updated 2012-02-20 16:08:51.382283)


Review request for bookkeeper.


Changes
-------

Attach a new patch addressing Ivan's comments. Also did some changes in EntryLogger to move GarbageCollectorThread into a separator class, which makes code more clear.  


Summary
-------

bookie server aggregates entries into entry log file. suppose there is lots of ledgers, each ledger has little messages. so a entry log file would contains messages from lots of different ledgers. if there is only one ledger not be deleted, the entry log file would not be removed, whose occupied disk space could not be reclaimed.


This addresses bug BOOKKEEPER-160.
    https://issues.apache.org/jira/browse/BOOKKEEPER-160


Diffs (updated)
-----

  bookkeeper-server/conf/bk_server.conf d005d01 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java d4ece94 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java aca66e6 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java 6bbe943 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/EntryLogTest.java f661e90 

Diff: https://reviews.apache.org/r/3874/diff


Testing
-------


Thanks,

Sijie