You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2012/11/21 20:37:14 UTC

request for inclusion in 0.20 of some fixes to AMQP 1.0 support

I have three issues fixed that I would like to merge onto the release 
branch for 0.20:

(1) QPID-4448[1]: fix credit checking on 0-10 path when message is of 
1.0 format

(2) QPID-4451[2]: wait for outgoing messages to settle when closing

(3) QPID-4452[3]: fix credit for producers

Of these only the first one even touches non-1.0 paths, and that only in 
the case where a 1.0 message is sent down an 0-10 connection. The risk 
is therefore very well contained.

--Gordon

[1] JIRA: https://issues.apache.org/jira/browse/QPID-4448

change on trunk: http://svn.apache.org/viewvc?rev=1412239&view=rev

[2] JIRA: https://issues.apache.org/jira/browse/QPID-4451

change on trunk: http://svn.apache.org/viewvc?rev=1412241&view=rev

[3] JIRA: https://issues.apache.org/jira/browse/QPID-4452

change on trunk: http://svn.apache.org/viewvc?rev=1412242&view=rev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Re: request for inclusion in 0.20 of some fixes to AMQP 1.0 support

Posted by Gordon Sim <gs...@redhat.com>.
On 11/21/2012 07:37 PM, Gordon Sim wrote:
> I have three issues fixed that I would like to merge onto the release
> branch for 0.20:
>
> (1) QPID-4448[1]: fix credit checking on 0-10 path when message is of
> 1.0 format
>
> (2) QPID-4451[2]: wait for outgoing messages to settle when closing
>
> (3) QPID-4452[3]: fix credit for producers
>
> Of these only the first one even touches non-1.0 paths, and that only in
> the case where a 1.0 message is sent down an 0-10 connection. The risk
> is therefore very well contained.

Another four issues found and fixed during some interop testing that I 
would like to include for 0.20. These are all small, low risk changes 
and only touch 1.0 codepaths:

(4) QPID-4459[4]: Sender doesn't settle messages

(5) QPID-4460[5]: after drain, full credit is not replenished

(6) QPID-4464[6]: broker does not set container name on AMQP 1.0 
connection open

(7) QPID-4465[7]: only send subject filter if subject is specified

> --Gordon
>
> [1] JIRA: https://issues.apache.org/jira/browse/QPID-4448
>
> change on trunk: http://svn.apache.org/viewvc?rev=1412239&view=rev
>
> [2] JIRA: https://issues.apache.org/jira/browse/QPID-4451
>
> change on trunk: http://svn.apache.org/viewvc?rev=1412241&view=rev
>
> [3] JIRA: https://issues.apache.org/jira/browse/QPID-4452
>
> change on trunk: http://svn.apache.org/viewvc?rev=1412242&view=rev

[4] JIRA: https://issues.apache.org/jira/browse/QPID-4459

change on trunk: http://svn.apache.org/viewvc?rev=1412960&view=rev

[5] JIRA: https://issues.apache.org/jira/browse/QPID-4460

change on trunk: http://svn.apache.org/viewvc?rev=1412961&view=rev

[6] JIRA: https://issues.apache.org/jira/browse/QPID-4464

change on trunk: http://svn.apache.org/viewvc?rev=1412962&view=rev

[7] JIRA: https://issues.apache.org/jira/browse/QPID-4465

change on trunk: http://svn.apache.org/viewvc?rev=1412963&view=rev

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


Re: request for inclusion in 0.20 of some fixes to AMQP 1.0 support

Posted by Rob Godfrey <ro...@gmail.com>.
Correction, JIRA: https://issues.apache.org/jira/browse/QPID-4453


On 21 November 2012 21:33, Rob Godfrey <ro...@gmail.com> wrote:

> I have one request for inclusion:
>
> QPID-4453[1] : ObjectMessage /w no body improperly converted to an AMQP
> message.
>
> This change only affects the AMQP 1.0 speaking JMS client rather than the
> separate 0-8/0-9/0-9-1/0-10 client and is a trivial modification to support
> null object messages
>
> -- Rob
>
> [1] JIRA: https://issues.apache.org/jira/browse/QPID-4454
>
> change on trunk:
> http://svn.apache.org/viewvc?view=revision&revision=1412270
>
>
>
> On 21 November 2012 20:37, Gordon Sim <gs...@redhat.com> wrote:
>
>> I have three issues fixed that I would like to merge onto the release
>> branch for 0.20:
>>
>> (1) QPID-4448[1]: fix credit checking on 0-10 path when message is of 1.0
>> format
>>
>> (2) QPID-4451[2]: wait for outgoing messages to settle when closing
>>
>> (3) QPID-4452[3]: fix credit for producers
>>
>> Of these only the first one even touches non-1.0 paths, and that only in
>> the case where a 1.0 message is sent down an 0-10 connection. The risk is
>> therefore very well contained.
>>
>> --Gordon
>>
>> [1] JIRA: https://issues.apache.org/**jira/browse/QPID-4448<https://issues.apache.org/jira/browse/QPID-4448>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412239&view=rev<http://svn.apache.org/viewvc?rev=1412239&view=rev>
>>
>> [2] JIRA: https://issues.apache.org/**jira/browse/QPID-4451<https://issues.apache.org/jira/browse/QPID-4451>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412241&view=rev<http://svn.apache.org/viewvc?rev=1412241&view=rev>
>>
>> [3] JIRA: https://issues.apache.org/**jira/browse/QPID-4452<https://issues.apache.org/jira/browse/QPID-4452>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412242&view=rev<http://svn.apache.org/viewvc?rev=1412242&view=rev>
>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.**org<de...@qpid.apache.org>
>> For additional commands, e-mail: dev-help@qpid.apache.org
>>
>>
>

Re: request for inclusion in 0.20 of some fixes to AMQP 1.0 support

Posted by Rob Godfrey <ro...@gmail.com>.
and another one (thanks to Hiram)

QPID-4455[1] : Queue browsers were not returning jms messages

Again this is isolated to the AMQP 1.0 JMS Client

-- Rob

[1] JIRA: https://issues.apache.org/jira/browse/QPID-4455

change on trunk: http://svn.apache.org/viewvc?view=revision&revision=1412280


On 21 November 2012 21:33, Rob Godfrey <ro...@gmail.com> wrote:

> I have one request for inclusion:
>
> QPID-4453[1] : ObjectMessage /w no body improperly converted to an AMQP
> message.
>
> This change only affects the AMQP 1.0 speaking JMS client rather than the
> separate 0-8/0-9/0-9-1/0-10 client and is a trivial modification to support
> null object messages
>
> -- Rob
>
> [1] JIRA: https://issues.apache.org/jira/browse/QPID-4454
>
> change on trunk:
> http://svn.apache.org/viewvc?view=revision&revision=1412270
>
>
>
> On 21 November 2012 20:37, Gordon Sim <gs...@redhat.com> wrote:
>
>> I have three issues fixed that I would like to merge onto the release
>> branch for 0.20:
>>
>> (1) QPID-4448[1]: fix credit checking on 0-10 path when message is of 1.0
>> format
>>
>> (2) QPID-4451[2]: wait for outgoing messages to settle when closing
>>
>> (3) QPID-4452[3]: fix credit for producers
>>
>> Of these only the first one even touches non-1.0 paths, and that only in
>> the case where a 1.0 message is sent down an 0-10 connection. The risk is
>> therefore very well contained.
>>
>> --Gordon
>>
>> [1] JIRA: https://issues.apache.org/**jira/browse/QPID-4448<https://issues.apache.org/jira/browse/QPID-4448>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412239&view=rev<http://svn.apache.org/viewvc?rev=1412239&view=rev>
>>
>> [2] JIRA: https://issues.apache.org/**jira/browse/QPID-4451<https://issues.apache.org/jira/browse/QPID-4451>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412241&view=rev<http://svn.apache.org/viewvc?rev=1412241&view=rev>
>>
>> [3] JIRA: https://issues.apache.org/**jira/browse/QPID-4452<https://issues.apache.org/jira/browse/QPID-4452>
>>
>> change on trunk: http://svn.apache.org/viewvc?**rev=1412242&view=rev<http://svn.apache.org/viewvc?rev=1412242&view=rev>
>>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.**org<de...@qpid.apache.org>
>> For additional commands, e-mail: dev-help@qpid.apache.org
>>
>>
>

Re: request for inclusion in 0.20 of some fixes to AMQP 1.0 support

Posted by Rob Godfrey <ro...@gmail.com>.
I have one request for inclusion:

QPID-4453[1] : ObjectMessage /w no body improperly converted to an AMQP
message.

This change only affects the AMQP 1.0 speaking JMS client rather than the
separate 0-8/0-9/0-9-1/0-10 client and is a trivial modification to support
null object messages

-- Rob

[1] JIRA: https://issues.apache.org/jira/browse/QPID-4454

change on trunk: http://svn.apache.org/viewvc?view=revision&revision=1412270


On 21 November 2012 20:37, Gordon Sim <gs...@redhat.com> wrote:

> I have three issues fixed that I would like to merge onto the release
> branch for 0.20:
>
> (1) QPID-4448[1]: fix credit checking on 0-10 path when message is of 1.0
> format
>
> (2) QPID-4451[2]: wait for outgoing messages to settle when closing
>
> (3) QPID-4452[3]: fix credit for producers
>
> Of these only the first one even touches non-1.0 paths, and that only in
> the case where a 1.0 message is sent down an 0-10 connection. The risk is
> therefore very well contained.
>
> --Gordon
>
> [1] JIRA: https://issues.apache.org/**jira/browse/QPID-4448<https://issues.apache.org/jira/browse/QPID-4448>
>
> change on trunk: http://svn.apache.org/viewvc?**rev=1412239&view=rev<http://svn.apache.org/viewvc?rev=1412239&view=rev>
>
> [2] JIRA: https://issues.apache.org/**jira/browse/QPID-4451<https://issues.apache.org/jira/browse/QPID-4451>
>
> change on trunk: http://svn.apache.org/viewvc?**rev=1412241&view=rev<http://svn.apache.org/viewvc?rev=1412241&view=rev>
>
> [3] JIRA: https://issues.apache.org/**jira/browse/QPID-4452<https://issues.apache.org/jira/browse/QPID-4452>
>
> change on trunk: http://svn.apache.org/viewvc?**rev=1412242&view=rev<http://svn.apache.org/viewvc?rev=1412242&view=rev>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.**org<de...@qpid.apache.org>
> For additional commands, e-mail: dev-help@qpid.apache.org
>
>