You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/09/30 07:53:13 UTC

Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as it does not pass even after fixing the issues. Also moving it to smoke folder as clearly it is a Basic Validation test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/
-----------------------------------------------------------

Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7646
    https://issues.apache.org/jira/browse/CLOUDSTACK-7646


Repository: cloudstack-git


Description
-------

It fails even after fixing the indetation and list index issues.
Also it has hard coded information about the nuage VSP plugin.

I request Suresh to take a look, move the hard coded information to config and read it from there.
Also it should be ok to move test to Smoke as it is a basic validation test?
Inputs from Suresh would be helpful.

Changes in this patch:
1. Fix indentation
2. Fix list index issues
3. Fix pep8 issues
4. Move it to Smoke folder


Diffs
-----

  test/integration/component/test_nuage_vsp.py 096b9d1 
  test/integration/smoke/test_nuage_vsp.py PRE-CREATION 

Diff: https://reviews.apache.org/r/26165/diff/


Testing
-------

Test case does not pass.


Thanks,

Gaurav Aradhye


Re: Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as it does not pass even after fixing the issues. Also moving it to smoke folder as clearly it is a Basic Validation test

Posted by Gaurav Aradhye <ga...@clogeny.com>.

> On Sept. 30, 2014, 12:05 p.m., SrikanteswaraRao Talluri wrote:
> > Let's fix all the outstanding issues related to the script before moving it to smoke test folder. Otherwise, It will effect the BVT pass rates.
> > 
> > OR
> > We can move this test to smoke folder and skip it until it is properly running or the setup with Nuage VSP is available..

Already marked test case as invalid and removed the basic/advanced tags.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/#review54954
-----------------------------------------------------------


On Sept. 30, 2014, 11:23 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26165/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:23 a.m.)
> 
> 
> Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7646
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7646
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It fails even after fixing the indetation and list index issues.
> Also it has hard coded information about the nuage VSP plugin.
> 
> I request Suresh to take a look, move the hard coded information to config and read it from there.
> Also it should be ok to move test to Smoke as it is a basic validation test?
> Inputs from Suresh would be helpful.
> 
> Changes in this patch:
> 1. Fix indentation
> 2. Fix list index issues
> 3. Fix pep8 issues
> 4. Move it to Smoke folder
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_nuage_vsp.py 096b9d1 
>   test/integration/smoke/test_nuage_vsp.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26165/diff/
> 
> 
> Testing
> -------
> 
> Test case does not pass.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as it does not pass even after fixing the issues. Also moving it to smoke folder as clearly it is a Basic Validation test

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/#review54954
-----------------------------------------------------------


Let's fix all the outstanding issues related to the script before moving it to smoke test folder. Otherwise, It will effect the BVT pass rates.

OR
We can move this test to smoke folder and skip it until it is properly running or the setup with Nuage VSP is available..

- SrikanteswaraRao Talluri


On Sept. 30, 2014, 5:53 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26165/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 5:53 a.m.)
> 
> 
> Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7646
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7646
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It fails even after fixing the indetation and list index issues.
> Also it has hard coded information about the nuage VSP plugin.
> 
> I request Suresh to take a look, move the hard coded information to config and read it from there.
> Also it should be ok to move test to Smoke as it is a basic validation test?
> Inputs from Suresh would be helpful.
> 
> Changes in this patch:
> 1. Fix indentation
> 2. Fix list index issues
> 3. Fix pep8 issues
> 4. Move it to Smoke folder
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_nuage_vsp.py 096b9d1 
>   test/integration/smoke/test_nuage_vsp.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26165/diff/
> 
> 
> Testing
> -------
> 
> Test case does not pass.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 26165: CLOUDSTACK-7646: test_nuage_vsp.py - Fixed basic indentation issues, list index issues, marked it as invalid because the test cases needs attention by the original author as it does not pass even after fixing the issues. Also moving it to smoke folder as clearly it is a Basic Validation test

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26165/#review55651
-----------------------------------------------------------

Ship it!


5408e0b8d195fa32a0a9a59ea2e3535ed083ee8e master

This still needs to be looked at for its inclusion in smoke suite.

- SrikanteswaraRao Talluri


On Sept. 30, 2014, 5:53 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26165/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 5:53 a.m.)
> 
> 
> Review request for cloudstack, Suresh Ramamurthy and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7646
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7646
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> It fails even after fixing the indetation and list index issues.
> Also it has hard coded information about the nuage VSP plugin.
> 
> I request Suresh to take a look, move the hard coded information to config and read it from there.
> Also it should be ok to move test to Smoke as it is a basic validation test?
> Inputs from Suresh would be helpful.
> 
> Changes in this patch:
> 1. Fix indentation
> 2. Fix list index issues
> 3. Fix pep8 issues
> 4. Move it to Smoke folder
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_nuage_vsp.py 096b9d1 
>   test/integration/smoke/test_nuage_vsp.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26165/diff/
> 
> 
> Testing
> -------
> 
> Test case does not pass.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>