You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2008/11/27 06:26:40 UTC

DO NOT REPLY [Bug 46304] New: SecurityUtil -- no method caching for event() or doFilterEvent() ?

https://issues.apache.org/bugzilla/show_bug.cgi?id=46304

           Summary: SecurityUtil -- no method caching for event() or
                    doFilterEvent() ?
           Product: Tomcat 6
           Version: 6.0.18
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P3
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: maslen@pobox.com


[No, this isn't a bug that has bitten me, I just noticed this in the code while
I was trying to get my head around what SecurityUtil does / doesn't do.  Also,
this is probably just a performance bug, not a real failure.  I noticed this
in the 6.0.18 source and confirmed that it's still on the trunk, even though
there have been code changes nearby, e.g revision 711600 ( https://svn.apache.org/viewcvs.cgi?view=rev&rev=711600 ) for issue 46011].

ApplicationFilterChain.internalDoFilterEvent() invokes
SecurityUtil.doAsPrivileged() for "doFilterEvent" and "event", but as far as
I can see, SecurityUtil.createMethodAndCacheIt() will never cache the Method
descriptors for those two methods -- bad (for performance)?


Also...  the fix for issue 46011 modified internalDoFilter(), but should there
be a similar modification in internalDoFilterEvent() too?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304





--- Comment #1 from Mark Thomas <ma...@apache.org>  2008-12-22 12:49:01 PST ---
I have fixed the internalDoFilterEvent() oart if this issue in trunk and
proposed it for 6.0.x


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304


Thomas Maslen <ma...@pobox.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maslen@pobox.com




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304


Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Mark Thomas <ma...@apache.org>  2009-01-14 15:39:26 PST ---
The patch has been applied to 6.0.x and will be included in 6.0.19 onwards.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 46304] SecurityUtil -- no method caching for event() or doFilterEvent() ?

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46304





--- Comment #2 from Mark Thomas <ma...@apache.org>  2008-12-22 13:13:08 PST ---
I've fixed the performance issues in trunk. I do not intend to propose this for
back port - it will be included with Tomcat 7.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org