You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (Commented) (JIRA)" <ji...@apache.org> on 2011/12/14 16:19:30 UTC

[jira] [Commented] (SOLR-1233) Remove restriction that /select cannot be used for /-prefixed request handlers via qt

    [ https://issues.apache.org/jira/browse/SOLR-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169425#comment-13169425 ] 

David Smiley commented on SOLR-1233:
------------------------------------

Seriously?! I was just about to report a security oriented bug that the likes of this is supported:
  http://localhost:8983/solr/select?qt=/dataimport&command=full-import
And get this... (as I say with a fiendish chuckle):
  http://localhost:8983/solr/select?qt=/update&stream.body=%3Cd%3E%3Cdelete%3E%3Cquery%3E*%3A*%3C%2Fquery%3E%3C%2Fdelete%3E%3Ccommit%2F%3E%3C%2Fd%3E

Booyaaa!  All your data is gone.

And no, disabling remote streaming in the schema won't save you this time.

Users expect /select to do a search and I don't think there should be any if's and's or but's about that expectation.  I don't really like the qt parameter and think people should prefix their request handlers with a slash and access them directly, but I don't expect to change anyone's mind here.  But if qt starts with a slash, then I think it should ideally not work, or for backwards compatibility sake, only support it if the target request handler has the same class as the current request handler.
                
> Remove restriction that /select cannot be used for /-prefixed request handlers via qt
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-1233
>                 URL: https://issues.apache.org/jira/browse/SOLR-1233
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1233.patch
>
>
> Currently /select?qt=/whatever is blocked by SolrDispatchFilter.  It makes life a lot easier to make general requests to any request handler (for example in SOLR-1230 where dataimport.jsp needs to request to arbitrary handler names).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org