You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/23 12:39:44 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

HyukjinKwon opened a new pull request #35001:
URL: https://github.com/apache/spark/pull/35001


   ### What changes were proposed in this pull request?
   
   This PR proposes to show ignored configurations and hide the warnings for configurations that are already set when invoking `SparkSession.builder.getOrCreate`.
   
   ### Why are the changes needed?
   
   Currently, `SparkSession.builder.getOrCreate()` is too noisy even when duplicate configurations are set. Users cannot easily tell which configurations are to fix. See the example below:
   
   ```bash
   ./bin/spark-shell --conf spark.abc=abc
   ```
   
   ```scala
   import org.apache.spark.sql.SparkSession
   spark.sparkContext.setLogLevel("DEBUG")
   SparkSession.builder.config("spark.abc", "abc").getOrCreate
   ```
   
   ```
   21:04:01.670 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
   ```
   
   It is straitforward when there are few configurations but it is difficult for users to figure out when there are too many configurations especially when these configurations are defined in a property file like {{spark-default.conf}} maintained separately by system admins in production.
   
   See also https://github.com/apache/spark/pull/34757#discussion_r769248275.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes.
   
   1. Show ignored configuration in debug level logs:
   
       ```bash
       ./bin/spark-shell --conf spark.abc=abc
       ```
   
       ```scala
       import org.apache.spark.sql.SparkSession
       spark.sparkContext.setLogLevel("DEBUG")
       SparkSession.builder
         .config("spark.sql.warehouse.dir", "2")
         .config("spark.abc", "abcb")
         .config("spark.abcd", "abcb4")
         .getOrCreate
       ```
   
       **Before:**
   
       ```
       21:13:28.360 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; the static sql configurations will not take effect.
       21:13:28.360 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
       ```
   
       **After**:
   
       ```
       20:34:30.619 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
       20:34:30.622 [main] DEBUG org.apache.spark.sql.SparkSession - Ignored static SQL configurations:
         spark.sql.warehouse.dir=2
       20:34:30.623 [main] DEBUG org.apache.spark.sql.SparkSession - Other ignored configurations:
         spark.abcd=abcb4
         spark.abc=abcb
       ```
   
   2. Do not show a configuration already explicitly set
   
       ```bash
       ./bin/spark-shell --conf spark.abc=abc
       ```
   
       ```scala
       import org.apache.spark.sql.SparkSession
       spark.sparkContext.setLogLevel("DEBUG")
       SparkSession.builder.config("spark.abc", "abc").getOrCreate  // **Ignore** warnings because it's already set in --conf
       SparkSession.builder.config("spark.abc.new", "abc").getOrCreate  // **Show** warnings for only configuration newly set.
       SparkSession.builder.config("spark.abc.new", "abc").getOrCreate  // **Ignore** warnings because it's set ^.
       ```
   
       **Before**:
   
       ```
       21:13:56.183 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
       21:13:56.356 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
       21:13:56.476 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing SparkSession; some spark core configurations may not take effect.
       ```
   
   
       **After:**
   
       ```
       20:36:36.251 [main] WARN  org.apache.spark.sql.SparkSession - Using an existing Spark session; only runtime SQL configurations will take effect.
       20:36:36.253 [main] DEBUG org.apache.spark.sql.SparkSession - Other ignored configurations:
         spark.abc.new=abc
       ```
   
   Note that there is no behaviour change on session state initialization when configurations are not set. For example:
   
   ```scala
   import org.apache.spark.sql.SparkSession
   spark.sparkContext.setLogLevel("DEBUG")
   SparkSession.builder.getOrCreate
   ```
   
   But the session state initialization can be triggered even for static SQL configurations set after this PR. Previously, it was not triggered. This would not introduce something user-facing or a bug but worth noting it.
   For runtime SQL configurations, the session state initialization in this code path was introduced at https://github.com/apache/spark/pull/15295.
   
   ### How was this patch tested?
   
   It was manually tested as shown above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000602480


   @Ngone51, the current change should address your comment (see 3. in Pr desscription)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000637376


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51018/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000609065


   Maybe we can have a UT in `SparkShellSuite`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000449917


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146522/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000316978


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50998/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000636741






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000610027


   > Maybe we can have a UT in `SparkShellSuite`?
   
   There is actually a bug I guess from switching to log4j 2 (see SPARK-37729). I would prefer to add it after this gets resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000447368


   **[Test build #146522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146522/testReport)** for PR 35001 at commit [`f58f6c3`](https://github.com/apache/spark/commit/f58f6c3aebea5b096f2aa3b97d14a13338babca7).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AngersZhuuuu commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000616346


   > > Maybe we can have a UT in `SparkShellSuite`?
   > 
   > There is actually a bug I guess from switching to log4j 2 (see [SPARK-37729](https://issues.apache.org/jira/browse/SPARK-37729)). I would prefer to add it after this gets resolved.
   
   Got it, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000283753


   **[Test build #146522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146522/testReport)** for PR 35001 at commit [`f58f6c3`](https://github.com/apache/spark/commit/f58f6c3aebea5b096f2aa3b97d14a13338babca7).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000286306


   **[Test build #146527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146527/testReport)** for PR 35001 at commit [`f710487`](https://github.com/apache/spark/commit/f7104870f0619f9a97fe8b62e812233a2aee184d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000449917


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146522/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000633975


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51018/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35001:
URL: https://github.com/apache/spark/pull/35001


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000359026


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50998/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000358990


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50998/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000452589


   **[Test build #146527 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146527/testReport)** for PR 35001 at commit [`f710487`](https://github.com/apache/spark/commit/f7104870f0619f9a97fe8b62e812233a2aee184d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000283753


   **[Test build #146522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146522/testReport)** for PR 35001 at commit [`f58f6c3`](https://github.com/apache/spark/commit/f58f6c3aebea5b096f2aa3b97d14a13338babca7).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000569949


   > I feel this could be a bit confused. Users may thought the value `abc` doesn't take effect for the conf `spark.abc.new`. However, it does. The thing is, it's actually the second set doesn't take effect here rather than the value itself.
   
   This actually was already there. The problem here is that users, for example, might pass some source specific options that Spark side does not now. Maybe we can filter out Spark's runtime configuration here though. Let me take a look while I am here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000277353


   cc @cloud-fan, @dongjoon-hyun @AngersZhuuuu @yaooqinn @maropu FYI when you find some time to review :-).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000637376


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/51018/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000455540


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146527/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000455540


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146527/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000605801


   **[Test build #146543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146543/testReport)** for PR 35001 at commit [`ae4616c`](https://github.com/apache/spark/commit/ae4616c9ad1429d79130a1008807d98b809d64e2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000605801


   **[Test build #146543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146543/testReport)** for PR 35001 at commit [`ae4616c`](https://github.com/apache/spark/commit/ae4616c9ad1429d79130a1008807d98b809d64e2).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000687404


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146543/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000619378


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/51018/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000286306


   **[Test build #146527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146527/testReport)** for PR 35001 at commit [`f710487`](https://github.com/apache/spark/commit/f7104870f0619f9a97fe8b62e812233a2aee184d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000359026


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50998/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000372540


   > 20:36:36.253 [main] DEBUG org.apache.spark.sql.SparkSession - Configurations that might not take effect:
   >  spark.abc.new=abc
   
   I feel this could be a bit confused. Users may thought the value `abc` doesn't take effect for the conf `spark.abc.new`. However, it does. The thing is, it's actually the second set doesn't take effect here rather than the value itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000638443


   late lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000685685


   **[Test build #146543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146543/testReport)** for PR 35001 at commit [`ae4616c`](https://github.com/apache/spark/commit/ae4616c9ad1429d79130a1008807d98b809d64e2).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #35001: [SPARK-37727][SQL] Show ignored confs & hide warnings for conf already set in SparkSession.builder.getOrCreate

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #35001:
URL: https://github.com/apache/spark/pull/35001#issuecomment-1000687404


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146543/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org