You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/21 09:49:06 UTC
[GitHub] [superset] EugeneTorap opened a new pull request, #22489: chore: Bump Pillow to 9.3.0
EugeneTorap opened a new pull request, #22489:
URL: https://github.com/apache/superset/pull/22489
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Fix https://github.com/apache/superset/issues/22235 to resolve next CVE:
upgrade Pillow to 9.3.0 to resolve https://github.com/advisories/GHSA-hr8g-f6r6-mr22, https://github.com/advisories/GHSA-m2vv-5vj5-2hm7, https://github.com/advisories/GHSA-q4mp-jvh2-76fj
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22489:
URL: https://github.com/apache/superset/pull/22489#issuecomment-1361629739
> > @codyml Can you see my #22489 PR and check failed cypress CI?
>
>
>
> @EugeneTorap Is it possible it's related to [this PR](https://github.com/apache/superset/pull/22302) (cc: @villebro)? It looks like it changed some permissions for examples, and while CI shows up as green in GitHub when I click through to [the Cypress run](https://cloud.cypress.io/projects/ukwxzo/runs/66078/overview) it looks like E2E failed with the same issues.
@codyml thanks for investigating this. This seems to be quite the accumulation of problems.. I can work on fixing/improving those tests, but in the short term I think we should disable them, as they're testing something that's assumed to be incorrect behavior right now; the examples should not be created by the Admin user, otherwise the welcome page is incorrect. Also, it's weird that those tests were passing on CI if my PR broke them..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #22489:
URL: https://github.com/apache/superset/pull/22489#issuecomment-1361879405
@villebro That all makes sense! I actually couldn't even tell that it was triggered by your PR when running locally at first because the Docker test setup names the admin user "Superset Admin" instead of "admin user" which caused a different fail 😪 skipping them for now sounds fine to me. No idea why the Cypress fail is showing up as green either!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
villebro merged PR #22489:
URL: https://github.com/apache/superset/pull/22489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22489:
URL: https://github.com/apache/superset/pull/22489#issuecomment-1361112010
# [Codecov](https://codecov.io/gh/apache/superset/pull/22489?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22489](https://codecov.io/gh/apache/superset/pull/22489?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1ea8ad) into [master](https://codecov.io/gh/apache/superset/commit/b954f8f56080270fa7f1f68aa962c9e789e96728?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b954f8f) will **decrease** coverage by `1.35%`.
> The diff coverage is `n/a`.
> :exclamation: Current head d1ea8ad differs from pull request most recent head 4f30146. Consider uploading reports for the commit 4f30146 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22489 +/- ##
==========================================
- Coverage 66.90% 65.55% -1.36%
==========================================
Files 1851 1851
Lines 70697 70697
Branches 7764 7764
==========================================
- Hits 47300 46345 -955
- Misses 21375 22330 +955
Partials 2022 2022
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.46% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `78.04% <ø> (ø)` | |
| presto | `52.35% <ø> (ø)` | |
| python | `78.41% <ø> (-2.84%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22489?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...set/advanced\_data\_type/plugins/internet\_address.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfYWRkcmVzcy5weQ==) | `16.32% <0.00%> (-79.60%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/boxplot.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2JveHBsb3QucHk=) | `20.51% <0.00%> (-79.49%)` | :arrow_down: |
| [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `11.76% <0.00%> (-77.95%)` | :arrow_down: |
| [...perset/advanced\_data\_type/plugins/internet\_port.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfcG9ydC5weQ==) | `18.75% <0.00%> (-77.09%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/rolling.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3JvbGxpbmcucHk=) | `21.87% <0.00%> (-68.75%)` | :arrow_down: |
| [...perset/utils/pandas\_postprocessing/contribution.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2NvbnRyaWJ1dGlvbi5weQ==) | `34.61% <0.00%> (-65.39%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/resample.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3Jlc2FtcGxlLnB5) | `37.50% <0.00%> (-62.50%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/select.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3NlbGVjdC5weQ==) | `38.46% <0.00%> (-61.54%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/rename.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3JlbmFtZS5weQ==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/compare.py](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2NvbXBhcmUucHk=) | `32.25% <0.00%> (-58.07%)` | :arrow_down: |
| ... and [59 more](https://codecov.io/gh/apache/superset/pull/22489/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
villebro commented on PR #22489:
URL: https://github.com/apache/superset/pull/22489#issuecomment-1363097497
Hotfix to unblock master branch: #22512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #22489: chore: Bump Pillow to 9.3.0
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #22489:
URL: https://github.com/apache/superset/pull/22489#issuecomment-1361499843
> @codyml Can you see my #22489 PR and check failed cypress CI?
@EugeneTorap Is it possible it's related to [this PR](https://github.com/apache/superset/pull/22302) (cc: @villebro)? It looks like it changed some permissions for examples, and while CI shows up as green in GitHub when I click through to [the Cypress run](https://cloud.cypress.io/projects/ukwxzo/runs/66078/overview) it looks like E2E failed with the same issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org