You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/18 01:26:20 UTC

[GitHub] [spark] mridulm commented on pull request #37528: [SPARK-40094][CORE] Send TaskEnd event when task failed with NotSerializableException or TaskOutputFileAlreadyExistException

mridulm commented on PR #37528:
URL: https://github.com/apache/spark/pull/37528#issuecomment-1218868817

   Took a quick look - the basic idea looked good to me.
   
   Review note: other uses of `abort` are not susceptible to the same issue because here we have marked the task as finished already here - and so as part of `killAllTaskAttempts` (due to `abort`), this task wont be cancelled/have failure event fired for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org