You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/05/22 13:18:10 UTC
[GitHub] [arrow-rs] alamb opened a new issue, #4257: FlightSQL: Add helpers to create `CommandGetXdbcTypeInfo` responses (`SqlInfoValue` and builders)
alamb opened a new issue, #4257:
URL: https://github.com/apache/arrow-rs/issues/4257
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
FlightSQL has several metadata APIs for a server to report its capabilities to the client. One such API is the `CommandGetXdbcTypeInfo` message that requires creating a DenseUnion (which is somewhat inconvenient in the Rust API):
https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/format/FlightSql.proto#L1058-L1116
@roeap noted in https://github.com/apache/arrow-rs/pull/4250#issuecomment-1556724021 that some of the existing work we did in IOx could be used by other rust projects implementing FlightSQL:
https://github.com/influxdata/influxdb_iox/blob/31b881376057bf7e50381519c4f5c9e15c1aee33/flightsql/src/xdbc_type_info/mod.rs
**Describe the solution you'd like**
1. Create a builder for `XdbcTypeInfo` responses in the arrow-rs flightsql implementation: https://github.com/apache/arrow-rs/tree/master/arrow-flight/src/sql
2. Create code that will convert these rust structs to the corresponding Arrow arrays
3. Add tests and docstrings showing how to use this builder
4. Update the example server https://github.com/apache/arrow-rs/blob/e2b9b1afebd45ab0dcdef260d662733bb3ac7d82/arrow-flight/examples/flight_sql_server.rs#L318-L326 to use this `XdbcTypeInfoBuilder`
I suggest following the model / copying code from IOx's [`XdbcTypeInfo`]:
https://github.com/influxdata/influxdb_iox/blob/31b881376057bf7e50381519c4f5c9e15c1aee33/flightsql/src/xdbc_type_info/value.rs#L146C16-L171
**Describe alternatives you've considered**
<!--
A clear and concise description of any alternative solutions or features you've considered.
-->
**Additional context**
Marking this as a good first issue as it is well specified and the implementation already exists for inspiration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #4257: FlightSQL: Add helpers to create `CommandGetXdbcTypeInfo` responses (`XdbcInfoValue` and builders)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #4257:
URL: https://github.com/apache/arrow-rs/issues/4257#issuecomment-1595001282
`label_issue.py` automatically added labels {'arrow'} from #4250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #4257: FlightSQL: Add helpers to create `CommandGetXdbcTypeInfo` responses (`XdbcInfoValue` and builders)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #4257: FlightSQL: Add helpers to create `CommandGetXdbcTypeInfo` responses (`XdbcInfoValue` and builders)
URL: https://github.com/apache/arrow-rs/issues/4257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org