You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Craig Condit (Jira)" <ji...@apache.org> on 2022/03/08 16:05:00 UTC
[jira] [Comment Edited] (YUNIKORN-165) API response fields can be returned as proper data structure rather than free text
[ https://issues.apache.org/jira/browse/YUNIKORN-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503032#comment-17503032 ]
Craig Condit edited comment on YUNIKORN-165 at 3/8/22, 4:04 PM:
----------------------------------------------------------------
Given the issues in YUNIKORN-1105, I think we should move to use absolute values within YuniKorn, as well as in the REST APIs. Clients can always add additional units to values on the presentation side, but we should only handle units during parsing of K8s values and use absolute values everywhere to avoid the issues present in YUNIKORN-1105. MilliCPU is somewhat necessary to avoid fractional values, but we can just declare that the absolute value of CPU usage is in fact milli-CPU.
On another note, I'd prefer not to do things just because "that's how K8s does it" because the YuniKorn core is meant to be agnostic.
was (Author: ccondit):
Given the issues in YUNIKORN-1105, I think we should move to use absolute values within YuniKorn, as well as in the REST APIs. Clients can always add additional units to values on the presentation side, but we should only handle units during parsing of K8s values and use absolute values everywhere to avoid the issues present in YUNIKORN-1105. MilliCPU is somewhat necessary to avoid fractional values, but we can just declare that the absolute value of CPU usage is in fact milli-CPU.
> API response fields can be returned as proper data structure rather than free text
> ----------------------------------------------------------------------------------
>
> Key: YUNIKORN-165
> URL: https://issues.apache.org/jira/browse/YUNIKORN-165
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common, webapp
> Reporter: Ayub Pathan
> Priority: Critical
>
> For most of the APIs, some of the fields are recorded as free text, this can be improved by sending them as proper data structure like map etc. This helps in easy consumption of the REST aPI response.
> For example:
> * Some fields from Apps API like resource,usedResource, partition can be returned as maps..
> {noformat}
> {
> "allocations": [
> {
> "allocationKey": "1e5225f7-4d60-400f-8b9b-5b7027b4c394",
> "allocationTags": null,
> "applicationId": "abcd",
> "nodeId": "docker-desktop",
> "partition": "default",
> "priority": "<nil>",
> "queueName": "root.development",
> "resource": "[memory:100 vcore:200]",
> "uuid": "b1b89eaf-81fb-4b2b-b20a-bf7bd96d3430"
> }
> ],
> "applicationID": "abcd",
> "applicationState": "Running",
> "partition": "[mycluster]default",
> "queueName": "root.development",
> "submissionTime": 1589740021170274400,
> "usedResource": "[memory:100 vcore:200]"
> }, {noformat}
>
> * same for nodes API response(fields like available, capacity, occupied, allocated) as well.
> {noformat}
> [
> {
> "nodesInfo": [
> {
> "RackName": "/rack-default",
> "allocated": "[memory:0 vcore:0]",
> "allocations": null,
> "available": "[ephemeral-storage:56450230179 hugepages-1Gi:0 hugepages-2Mi:0 memory:1824 pods:110 vcore:3250]",
> "capacity": "[ephemeral-storage:56450230179 hugepages-1Gi:0 hugepages-2Mi:0 memory:1982 pods:110 vcore:4000]",
> "hostName": "docker-desktop",
> "nodeID": "docker-desktop",
> "occupied": "[memory:158 vcore:750]",
> "schedulable": true
> }
> ],
> "partitionName": "[mycluster]default"
> }
> ] {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org