You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Zhongxin Yan (Jira)" <ji...@apache.org> on 2025/12/09 04:41:00 UTC
[jira] [Updated] (LANG-1800) Incorrect grammar and unclear wording in RandomStringUtils#random method
[ https://issues.apache.org/jira/browse/LANG-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhongxin Yan updated LANG-1800:
-------------------------------
Description:
[!https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4|width=678,height=84!|https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4]
The IllegalArgumentException thrown when validating the end parameter contains incorrect English grammar (“greater then” instead of “greater than”) and awkward phrasing. This may cause confusion for users interpreting the API error message.
{code:java}
public static String random(int count, int start, int end, final boolean letters, final boolean numbers, final char[] chars, final Random random){code}
{{ [github pr |https://github.com/apache/commons-lang/pull/1520]}}
was:
[!https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4|width=678,height=84!|https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4]
{code:java}
public static String random(int count, int start, int end, final boolean letters, final boolean numbers, final char[] chars, final Random random){code}
{{ [github pr |https://github.com/apache/commons-lang/pull/1520]}}
> Incorrect grammar and unclear wording in RandomStringUtils#random method
> ------------------------------------------------------------------------
>
> Key: LANG-1800
> URL: https://issues.apache.org/jira/browse/LANG-1800
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Affects Versions: 3.20.0
> Reporter: Zhongxin Yan
> Priority: Major
>
> [!https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4|width=678,height=84!|https://private-user-images.githubusercontent.com/24890794/524085462-38dc1b7f-409c-44e5-b016-91d48747c5ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjUyNTUyOTIsIm5iZiI6MTc2NTI1NDk5MiwicGF0aCI6Ii8yNDg5MDc5NC81MjQwODU0NjItMzhkYzFiN2YtNDA5Yy00NGU1LWIwMTYtOTFkNDg3NDdjNWFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA5VDA0MzYzMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZDRlYjVmMzYzOTM5ZTQyYzY1MjZmYmIxNDRhMDdkODI2MmIwNDM2NWI1YTE4ZWJkMGVkZTBmYjg0MWM4ZWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lMDoTt4d0Oh8iLbGrfZetC8cgy8a0NmX_-3tpvbYJq4]
> The IllegalArgumentException thrown when validating the end parameter contains incorrect English grammar (“greater then” instead of “greater than”) and awkward phrasing. This may cause confusion for users interpreting the API error message.
> {code:java}
> public static String random(int count, int start, int end, final boolean letters, final boolean numbers, final char[] chars, final Random random){code}
> {{ [github pr |https://github.com/apache/commons-lang/pull/1520]}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)