You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/02/05 21:02:20 UTC

[GitHub] huijunw commented on a change in pull request #3189: Add metrics for total time spent on user logic

huijunw commented on a change in pull request #3189: Add metrics for total time spent on user logic
URL: https://github.com/apache/incubator-heron/pull/3189#discussion_r254044795
 
 

 ##########
 File path: heron/common/src/java/org/apache/heron/common/utils/metrics/BoltMetrics.java
 ##########
 @@ -127,6 +130,7 @@ public void failedTuple(String streamId, String sourceComponent, long latency) {
   public void executeTuple(String streamId, String sourceComponent, long latency) {
     executeCount.incr();
     executeLatency.update(latency);
+    executeTimeNs.incrBy(latency);
 
 Review comment:
   is this equation correct ? executeLatency x executeCount = executeTimeNs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services