You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2025/08/28 23:34:59 UTC
[PR] fix(mongodb): update filter composition to handle MongoDB 5.x driver [beam]
liferoad opened a new pull request, #36004:
URL: https://github.com/apache/beam/pull/36004
Modify filter composition logic to avoid $and wrapping when possible by merging conditions directly into a composite Document. This addresses behavior changes in MongoDB driver 5.x while maintaining backward compatibility.
Fixes https://github.com/apache/beam/issues/35514
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mongodb): update filter composition to handle MongoDB 5.x driver [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #36004:
URL: https://github.com/apache/beam/pull/36004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mongodb): update filter composition to handle MongoDB 5.x driver [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad commented on code in PR #36004:
URL: https://github.com/apache/beam/pull/36004#discussion_r2310165138
##########
sdks/java/extensions/sql/build.gradle:
##########
@@ -41,6 +41,8 @@ applyJavaNature(
],
// javacc generated code produces lint warnings
disableLintWarnings: ['dep-ann', 'rawtypes'],
+ // Disable SpotBugs due to ASM bytecode analysis issue with BeamCalcRel class
Review Comment:
@Abacn is it ok to disable this? Without this, it keeps complaining bytecode error.
```
Exception analyzing org.apache.beam.sdk.extensions.sql.impl.rel.BeamCalcRel using detector edu.umd.cs.findbugs.detect.UnnecessaryEnvUsage
java.lang.ArrayIndexOutOfBoundsException: Index 65536 out of bounds for length 334
At edu.umd.cs.findbugs.asm.FBClassReader.readLabel(FBClassReader.java:50)
At org.objectweb.asm.ClassReader.createLabel(ClassReader.java:2711)
At org.objectweb.asm.ClassReader.readTypeAnnotations(ClassReader.java:2777)
At org.objectweb.asm.ClassReader.readCode(ClassReader.java:1929)
At org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1515)
At org.objectweb.asm.ClassReader.accept(ClassReader.java:745)
At edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
At org.objectweb.asm.ClassReader.accept(ClassReader.java:425)
At edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:552)
At edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:737)
At edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:79)
At edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
At edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:261)
At edu.umd.cs.findbugs.ba.XFactory.getXClass(XFactory.java:693)
At edu.umd.cs.findbugs.ba.AnalysisContext.setAppClassList(AnalysisContext.java:975)
At edu.umd.cs.findbugs.FindBugs2.setAppClassList(FindBugs2.java:909)
At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:252)
At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395)
At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231)
> Task :sdks:java:extensions:sql:spotbugsMain FAILED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mongodb): update filter composition to handle MongoDB 5.x driver [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #36004:
URL: https://github.com/apache/beam/pull/36004#discussion_r2310374409
##########
sdks/java/extensions/sql/build.gradle:
##########
@@ -41,6 +41,8 @@ applyJavaNature(
],
// javacc generated code produces lint warnings
disableLintWarnings: ['dep-ann', 'rawtypes'],
+ // Disable SpotBugs due to ASM bytecode analysis issue with BeamCalcRel class
Review Comment:
I've seen this error when working on #35684 yesterday (https://github.com/apache/beam/actions/runs/17308224909) after another commit it was gone. Likely a spotbugs bug. Could leave this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mongodb): update filter composition to handle MongoDB 5.x driver [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36004:
URL: https://github.com/apache/beam/pull/36004#issuecomment-3235429058
Assigning reviewers:
R: @ahmedabu98 for label java.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org