You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by hb...@apache.org on 2011/10/23 21:02:21 UTC

svn commit: r1187949 - in /maven/maven-3/trunk/maven-plugin-api/src: main/mdo/plugin.mdo test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java test/resources/plugin.xml

Author: hboutemy
Date: Sun Oct 23 19:02:21 2011
New Revision: 1187949

URL: http://svn.apache.org/viewvc?rev=1187949&view=rev
Log:
restored attribute removed in r1185847 since it is generated by maven-plugin-tools-java

Modified:
    maven/maven-3/trunk/maven-plugin-api/src/main/mdo/plugin.mdo
    maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
    maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml

Modified: maven/maven-3/trunk/maven-plugin-api/src/main/mdo/plugin.mdo
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-plugin-api/src/main/mdo/plugin.mdo?rev=1187949&r1=1187948&r2=1187949&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-plugin-api/src/main/mdo/plugin.mdo (original)
+++ maven/maven-3/trunk/maven-plugin-api/src/main/mdo/plugin.mdo Sun Oct 23 19:02:21 2011
@@ -430,6 +430,12 @@ under the License.
           <type>String</type>
           <description>Parameter expression.</description>
         </field>
+        <field xml.attribute="true" xml.tagName="implementation">
+          <name>implementation</name>
+          <version>1.0.0</version>
+          <type>String</type>
+          <description></description>
+        </field>
         <field xml.attribute="true" xml.tagName="default-value">
           <name>defaultValue</name>
           <version>1.0.0</version>

Modified: maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java?rev=1187949&r1=1187948&r2=1187949&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java (original)
+++ maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java Sun Oct 23 19:02:21 2011
@@ -94,6 +94,7 @@ public class PluginDescriptorBuilderTest
 
         assertEquals( "${jar.finalName}", pc.getValue() );
         assertEquals( "${project.build.finalName}", pc.getAttribute( "default-value" ) );
+        assertEquals( "java.lang.String", pc.getAttribute( "implementation" ) );
 
         Parameter mp = md.getParameters().get( 0 );
 

Modified: maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml?rev=1187949&r1=1187948&r2=1187949&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml (original)
+++ maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml Sun Oct 23 19:02:21 2011
@@ -43,7 +43,7 @@
         </parameter>
       </parameters>
       <configuration>
-        <finalName default-value="${project.build.finalName}">${jar.finalName}</finalName>
+        <finalName implementation="java.lang.String" default-value="${project.build.finalName}">${jar.finalName}</finalName>
       </configuration>
       <requirements>
         <requirement>