You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/02/02 19:46:30 UTC
Review Request: OOZIE-673: Offset and len option not working as expected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-673
This addresses bug oozie-673.
https://issues.apache.org/jira/browse/oozie-673
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
trunk/core/src/main/resources/oozie-default.xml 1239737
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
Diff: https://reviews.apache.org/r/3738/diff
Testing
-------
test for sorting added
tested after running cron example
Thanks,
Virag
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4775
-----------------------------------------------------------
Ship it!
- Alejandro
On 2012-02-02 20:59:14, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3738/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 20:59:14)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-673
>
>
> This addresses bug oozie-673.
> https://issues.apache.org/jira/browse/oozie-673
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
> trunk/core/src/main/resources/oozie-default.xml 1239737
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737
>
> Diff: https://reviews.apache.org/r/3738/diff
>
>
> Testing
> -------
>
> test for sorting added
> tested after running cron example
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4787
-----------------------------------------------------------
Ship it!
committing and will close
- Mohammad
On 2012-02-02 20:59:14, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3738/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 20:59:14)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-673
>
>
> This addresses bug oozie-673.
> https://issues.apache.org/jira/browse/oozie-673
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
> trunk/core/src/main/resources/oozie-default.xml 1239737
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737
>
> Diff: https://reviews.apache.org/r/3738/diff
>
>
> Testing
> -------
>
> test for sorting added
> tested after running cron example
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/
-----------------------------------------------------------
(Updated 2012-02-02 20:59:14.944877)
Review request for oozie.
Changes
-------
Integrating Alejandro's comment about default value to be 1000.
Regarding that comment, the info api might break if the client has 10,000 actions. Now they will have to loop 10 times to get all actions. But that can be addressed by overriding this value in oozie-site. I agree its better to have a lower value to avoid high memory and n/w usage.
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-673
This addresses bug oozie-673.
https://issues.apache.org/jira/browse/oozie-673
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
trunk/core/src/main/resources/oozie-default.xml 1239737
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737
Diff: https://reviews.apache.org/r/3738/diff
Testing
-------
test for sorting added
tested after running cron example
Thanks,
Virag
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4774
-----------------------------------------------------------
Looks good.
A 10000 resultset by default means a large DB result, caching locally in the server (because the JSON structure is built in memory) and then network traffic.
Still, I'd argue a more sensible default is 1000. I don't see how this will break the client as it is a just a different number of rows being returned.
- Alejandro
On 2012-02-02 20:00:50, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3738/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 20:00:50)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-673
>
>
> This addresses bug oozie-673.
> https://issues.apache.org/jira/browse/oozie-673
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
> trunk/core/src/main/resources/oozie-default.xml 1239737
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737
>
> Diff: https://reviews.apache.org/r/3738/diff
>
>
> Testing
> -------
>
> test for sorting added
> tested after running cron example
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/
-----------------------------------------------------------
(Updated 2012-02-02 20:00:50.659432)
Review request for oozie.
Changes
-------
Integrating Alejandro's comments
Adding info to twiki
Summary
-------
https://issues.apache.org/jira/browse/OOZIE-673
This addresses bug oozie-673.
https://issues.apache.org/jira/browse/oozie-673
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
trunk/core/src/main/resources/oozie-default.xml 1239737
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737
Diff: https://reviews.apache.org/r/3738/diff
Testing
-------
test for sorting added
tested after running cron example
Thanks,
Virag
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Virag Kothari <vi...@yahoo-inc.com>.
> On 2012-02-02 18:54:41, Alejandro Abdelnur wrote:
> > trunk/core/src/main/resources/oozie-default.xml, line 1519
> > <https://reviews.apache.org/r/3738/diff/1/?file=71881#file71881line1519>
> >
> > the default value in oozie-default.xml and in the code should be the same. and 100000 seems a bit too high, shouldn't we cap on 1000 as default?
the default value is kept high to not break the current info api. There are some coord jobs with around 10,000 actions. But, I understand that 100000 is also too high. So, should I make it 10,000?
Also will reflect that value in the code
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4771
-----------------------------------------------------------
On 2012-02-02 18:46:30, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3738/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 18:46:30)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-673
>
>
> This addresses bug oozie-673.
> https://issues.apache.org/jira/browse/oozie-673
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
> trunk/core/src/main/resources/oozie-default.xml 1239737
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
>
> Diff: https://reviews.apache.org/r/3738/diff
>
>
> Testing
> -------
>
> test for sorting added
> tested after running cron example
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-673: Offset and len option not working as expected
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4771
-----------------------------------------------------------
trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/3738/#comment10493>
the default value in oozie-default.xml and in the code should be the same. and 100000 seems a bit too high, shouldn't we cap on 1000 as default?
- Alejandro
On 2012-02-02 18:46:30, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3738/
> -----------------------------------------------------------
>
> (Updated 2012-02-02 18:46:30)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-673
>
>
> This addresses bug oozie-673.
> https://issues.apache.org/jira/browse/oozie-673
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737
> trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java 1239737
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737
> trunk/core/src/main/resources/oozie-default.xml 1239737
> trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1239737
>
> Diff: https://reviews.apache.org/r/3738/diff
>
>
> Testing
> -------
>
> test for sorting added
> tested after running cron example
>
>
> Thanks,
>
> Virag
>
>