You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Oleg Kalnichevski (Jira)" <ji...@apache.org> on 2021/04/13 19:04:00 UTC

[jira] [Commented] (HTTPCORE-673) AbstractH2StreamMultiplexer only partially consumes unknown settings

    [ https://issues.apache.org/jira/browse/HTTPCORE-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320478#comment-17320478 ] 

Oleg Kalnichevski commented on HTTPCORE-673:
--------------------------------------------

[~awilkinson] Many thanks for reporting the defect and providing a reproducer. This change-set fixes the problem for me locally. Please review / re-test.

https://github.com/ok2c/httpcomponents-core/commit/ae13feddf837034a3087dd97937f25cd21c2dd59

Oleg

> AbstractH2StreamMultiplexer only partially consumes unknown settings
> --------------------------------------------------------------------
>
>                 Key: HTTPCORE-673
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-673
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore
>    Affects Versions: 5.1
>            Reporter: Andy Wilkinson
>            Priority: Major
>             Fix For: 5.1.1, 5.2-alpha1
>
>
> I originally [reported|https://github.com/eclipse/jetty.project/issues/6164] this to the Jetty project but they have identified that the problem is in HttpCore's {{AbstractH2StreamMultiplexer}}. Jetty 10 has added support for {{SETTINGS_ENABLE_CONNECT_PROTOCOL}}. When consuming the settings frame, {{AbstractH2StreamMultiplexer}} consumes the code but, as it has no {{H2Param}} for it, it does not consume the value. This partial consumption results in an failure later on.
> The problem can be reproduced using [this sample project|https://github.com/wilkinsona/jetty-h2c-problem].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org