You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/24 12:38:34 UTC
[GitHub] [flink] SteNicholas opened a new pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
SteNicholas opened a new pull request #14742:
URL: https://github.com/apache/flink/pull/14742
## What is the purpose of the change
*The configuration `parallelism.default` for table environment doesn't take effect for `TableEnvironment#explain`. Because `PlannerBase#translateToRel` doesn't invoke `overrideEnvParallelism` which configures the configuration into underlying `StreamExecutionEnvironment` and is invoked in `translate`. Method `overrideEnvParallelism` should be invoked in `translateToRel` and removed from `translate`.*
## Brief change log
- *`PlannerBase#translateToRel` invokes the method `overrideEnvParallelism` which configures the configuration into underlying `StreamExecutionEnvironment`.*
## Verifying this change
- *Modify `testStreamTableEnvironmentExecutionExplain` of `TableEnvironmentTest` to verify the test case whether the configuration `parallelism.default` takes effect in `TableEnvironment#explainSql` or not.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766564938
@wuchong sorry for the failure of scala style compile. I have updated the violation of `TableEnvironmentTest`. You could help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14742:
URL: https://github.com/apache/flink/pull/14742#discussion_r563486211
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -106,10 +107,23 @@ class TableEnvironmentTest {
@Test
def testStreamTableEnvironmentExecutionExplain(): Unit = {
val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
- execEnv.setParallelism(1)
+ execEnv.setParallelism(4)
val settings = EnvironmentSettings.newInstance().inStreamingMode().build()
- val tEnv = StreamTableEnvironment.create(execEnv, settings)
+ var tEnv = StreamTableEnvironment.create(execEnv, settings)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+
+ tEnv = StreamTableEnvironment.create(
+ StreamExecutionEnvironment.getExecutionEnvironment,
+ settings)
+ val conf = new Configuration()
+ conf.setInteger("parallelism.default", 4)
+ tEnv.getConfig.addConfiguration(conf)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+ }
+ def testStreamTableEnvironmentExecutionExplain(tEnv: TableEnvironment): Unit = {
Review comment:
Add `private` modifier and the method name would be better not start with `test` prefix, e.g. `verifyExplainExecutionPlan(tEnv)`.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -106,10 +107,23 @@ class TableEnvironmentTest {
@Test
def testStreamTableEnvironmentExecutionExplain(): Unit = {
val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
- execEnv.setParallelism(1)
+ execEnv.setParallelism(4)
val settings = EnvironmentSettings.newInstance().inStreamingMode().build()
- val tEnv = StreamTableEnvironment.create(execEnv, settings)
+ var tEnv = StreamTableEnvironment.create(execEnv, settings)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+
+ tEnv = StreamTableEnvironment.create(
+ StreamExecutionEnvironment.getExecutionEnvironment,
+ settings)
+ val conf = new Configuration()
+ conf.setInteger("parallelism.default", 4)
+ tEnv.getConfig.addConfiguration(conf)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
Review comment:
I would like to separate them into different methods, then the failed message will be more clear to help find which is failed.
For example, we can have `testExplainExecutionPlanWithEnvParallelism` and `testExplainExecutionPlanWithConfParallelism`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766564938
@wuchong, sorry for the failure of scala style compile. I have updated the violation of `TableEnvironmentTest`. You could help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424)
* d4cd0c0c31c63371b4ba7f7da158ae541762acc4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
}, {
"hash" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424)
* d4cd0c0c31c63371b4ba7f7da158ae541762acc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437)
* 2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14742:
URL: https://github.com/apache/flink/pull/14742#discussion_r563486211
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -106,10 +107,23 @@ class TableEnvironmentTest {
@Test
def testStreamTableEnvironmentExecutionExplain(): Unit = {
val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
- execEnv.setParallelism(1)
+ execEnv.setParallelism(4)
val settings = EnvironmentSettings.newInstance().inStreamingMode().build()
- val tEnv = StreamTableEnvironment.create(execEnv, settings)
+ var tEnv = StreamTableEnvironment.create(execEnv, settings)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+
+ tEnv = StreamTableEnvironment.create(
+ StreamExecutionEnvironment.getExecutionEnvironment,
+ settings)
+ val conf = new Configuration()
+ conf.setInteger("parallelism.default", 4)
+ tEnv.getConfig.addConfiguration(conf)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+ }
+ def testStreamTableEnvironmentExecutionExplain(tEnv: TableEnvironment): Unit = {
Review comment:
Add `private` modifier and the method name would be better not start with `test` prefix, e.g. `verifyExplainExecutionPlan(tEnv)`.
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -106,10 +107,23 @@ class TableEnvironmentTest {
@Test
def testStreamTableEnvironmentExecutionExplain(): Unit = {
val execEnv = StreamExecutionEnvironment.getExecutionEnvironment
- execEnv.setParallelism(1)
+ execEnv.setParallelism(4)
val settings = EnvironmentSettings.newInstance().inStreamingMode().build()
- val tEnv = StreamTableEnvironment.create(execEnv, settings)
+ var tEnv = StreamTableEnvironment.create(execEnv, settings)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
+
+ tEnv = StreamTableEnvironment.create(
+ StreamExecutionEnvironment.getExecutionEnvironment,
+ settings)
+ val conf = new Configuration()
+ conf.setInteger("parallelism.default", 4)
+ tEnv.getConfig.addConfiguration(conf)
+
+ testStreamTableEnvironmentExecutionExplain(tEnv)
Review comment:
I would like to separate them into different methods, then the failed message will be more clear to help find which is failed.
For example, we can have `testExplainExecutionPlanWithEnvParallelism` and `testExplainExecutionPlanWithConfParallelism`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766564938
@wuchong sorry for the failure of scala style compile. I have updated the violation of `TableEnvironmentTest`. You could help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766341700
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d541df916f27528c8be8e9fc2daa36d535e78061 (Sun Jan 24 12:41:01 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766341700
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a (Fri May 28 07:13:14 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766564938
@wuchong, sorry for the failure of scala style compile. I have updated the violation of `TableEnvironmentTest`. You could help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424)
* d4cd0c0c31c63371b4ba7f7da158ae541762acc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
}, {
"hash" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442",
"triggerID" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d541df916f27528c8be8e9fc2daa36d535e78061 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424)
* d4cd0c0c31c63371b4ba7f7da158ae541762acc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437)
* 2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766368245
Compile is failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766368245
Compile is failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
}, {
"hash" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442",
"triggerID" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d4cd0c0c31c63371b4ba7f7da158ae541762acc4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437)
* 2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14742:
URL: https://github.com/apache/flink/pull/14742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14742:
URL: https://github.com/apache/flink/pull/14742#issuecomment-766343148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12424",
"triggerID" : "d541df916f27528c8be8e9fc2daa36d535e78061",
"triggerType" : "PUSH"
}, {
"hash" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12437",
"triggerID" : "d4cd0c0c31c63371b4ba7f7da158ae541762acc4",
"triggerType" : "PUSH"
}, {
"hash" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442",
"triggerID" : "2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2ce2e5da10fee1d9ef02bdc317a9fb1a321a657a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12442)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14742: [FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14742:
URL: https://github.com/apache/flink/pull/14742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org