You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "equanz (via GitHub)" <gi...@apache.org> on 2026/10/15 06:53:25 UTC

[PR] [fix][auth] Allow natural exit with token suppliers [pulsar-client-node]

equanz opened a new pull request, #510:
URL: https://github.com/apache/pulsar-client-node/pull/510

   ### Motivation
   
   Using a token supplier can keep Node.js running after `client.close()` completes.
   The supplier's thread-safe function keeps the event loop alive while the Authentication object remains reachable.
   
   ### Modifications
   
   - Unref the supplier's thread-safe function so it allows natural process exit
   - Keep callback state alive through finalization and avoid releasing an already finalized thread-safe function
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - Add process-exit regression tests for synchronous and asynchronous suppliers
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   Fixes process shutdown behavior without changing the public API or configuration.
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [fix][auth] Allow natural exit with token suppliers [pulsar-client-node]

Posted by "equanz (via GitHub)" <gi...@apache.org>.
equanz closed pull request #510: [fix][auth] Allow natural exit with token suppliers
URL: https://github.com/apache/pulsar-client-node/pull/510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org