[GitHub] [iotdb] xuanronaldo commented on a change in pull request #4477: [IoTDB-1989] IoTDB support insert data from Spark

[GitBox <gi...@apache.org>]

xuanronaldo commented on a change in pull request #4477:
URL: https://github.com/apache/iotdb/pull/4477#discussion_r758015134



##########
File path: spark-iotdb-connector/pom.xml
##########
@@ -97,22 +74,31 @@
         <dependency>
             <groupId>org.apache.spark</groupId>
             <artifactId>spark-core_2.11</artifactId>
+            <version>${spark.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.apache.spark</groupId>
             <artifactId>spark-sql_2.11</artifactId>
+            <version>${spark.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
             <groupId>org.scala-lang</groupId>
             <artifactId>scala-library</artifactId>
+            <version>${scala.version}</version>
         </dependency>
         <dependency>
             <groupId>org.scalatest</groupId>
             <artifactId>scalatest_2.11</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>net.jpountz.lz4</groupId>
+            <artifactId>lz4</artifactId>
+            <version>1.3.0</version>
+            <scope>provided</scope>
+        </dependency>

Review comment:
       It is confilcted with the Spark, so it is marked by `provided`.

##########
File path: spark-iotdb-connector/src/main/scala/org/apache/iotdb/spark/db/DefaultSource.scala
##########
@@ -34,10 +37,27 @@ private[iotdb] class DefaultSource extends RelationProvider with DataSourceRegis
 
     val iotdbOptions = new IoTDBOptions(parameters)
 
-    if (iotdbOptions.url == null || iotdbOptions.sql == null) {
-      sys.error("IoTDB url or sql not specified")
+    if (iotdbOptions.sql.equals("")) {
+      sys.error("sql not specified")
     }

Review comment:
       ok，got this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org