You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2013/09/07 22:47:51 UTC

[jira] [Commented] (MATH-1014) Remove optimizer from constructor of "CurveFitter" subclasses

    [ https://issues.apache.org/jira/browse/MATH-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761121#comment-13761121 ] 

Gilles commented on MATH-1014:
------------------------------

"HarmonicCurveFitter" created in revision 1520807.

                
> Remove optimizer from constructor of "CurveFitter" subclasses
> -------------------------------------------------------------
>
>                 Key: MATH-1014
>                 URL: https://issues.apache.org/jira/browse/MATH-1014
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>              Labels: api-change
>             Fix For: 4.0, 3.3
>
>         Attachments: MATH-1014.zip, MATH-1014.zip
>
>
> In package "o.a.c.m.fitting", the constructor of the concrete subclasses of "CurveFitter" (currently: "PolynomialFitter", "GaussianFitter", "HarmonicFitter") takes a "MultivariateVectorOptimizer" argument.
> However, assuming that there is _one_ best choice for the optimizer (given the parametric function), this argument should not be left to the user's choice (i.e. it should be hidden within the class, and the best optimizer be transparently selected).
> Thus, I would propose to deprecate the non-default constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira