You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by K0zka <gi...@git.apache.org> on 2015/04/13 20:12:07 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
GitHub user K0zka opened a pull request:
https://github.com/apache/cloudstack/pull/163
CLOUDSTACK-8335: use libvirt from central repository
Signed-off-by: Laszlo Hornyak <la...@gmail.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/K0zka/cloudstack CLOUDSTACK-8335
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #163
----
commit e1cc7897f57e13c9a73b90dd61e2f3551a519a2f
Author: Laszlo Hornyak <la...@gmail.com>
Date: 2015-04-13T16:59:26Z
CLOUDSTACK-8335: use libvirt from central repository
Signed-off-by: Laszlo Hornyak <la...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/163#issuecomment-93363759
Awesome!
Thanks, @K0zka :)
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28395092
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.libvirt</groupId>
+ <groupId>com.github.K0zka</groupId>
--- End diff --
@K0zka in that case if you'll be maintaining it then we should merge it. Since, I'm not sure I'll wait for any of the KVM people to comment on it. (Wido, Kishan, Marcus?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28268011
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.libvirt</groupId>
+ <groupId>com.github.K0zka</groupId>
--- End diff --
Hi Rohit,
I updated the group ID to that because I can publish with that group ID only and not with org.libvirt, unfortunately the libvirt maintainers do not seem to be interested in pushing their artifacts to central repo.
I agree that the groupId does not look good, but I haven't found another way. I will try to keep an up to date version in central repo untl libvirt maintainers accept the changes I have done on the pom.xml and publish to maven central, but this may take quite some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by kishankavala <gi...@git.apache.org>.
Github user kishankavala commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28395781
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.libvirt</groupId>
+ <groupId>com.github.K0zka</groupId>
--- End diff --
@K0zka Can we use something like org.apache.cloudstack.libvirt instead ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28400164
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.libvirt</groupId>
+ <groupId>com.github.K0zka</groupId>
--- End diff --
@kishankavala yes that is possible. I have to see how that could work together with the apache infrastructure, but I will be working on it. I will close this PR for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/163#discussion_r28265861
--- Diff: plugins/hypervisors/kvm/pom.xml ---
@@ -45,7 +38,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
- <groupId>org.libvirt</groupId>
+ <groupId>com.github.K0zka</groupId>
--- End diff --
is this fine? com.github.K0zka?
@K0zka will you be maintaining this repo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka commented on the pull request:
https://github.com/apache/cloudstack/pull/163#issuecomment-93350242
Hi @wilderrodrigues
Patch 9a38b2f7de79888cdbbb2dca2305d6ec10f81ee0 should be a solution for *most* of the problem. The objective here is to completely get rid of the libvirt.org (and other 3rd party) repository as a step towards sharing CS artifacts in maven central. I will send you PRs!
Best regards,
Laszlo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/163#issuecomment-93274204
Hi @K0zka ,
I have to fix a bug on 4.4.2 and when trying to build from source got an issue with the old libvirt groupid: could not simple download it. Thus could not build.
[ERROR] Failed to execute goal on project cloud-plugin-hypervisor-kvm: Could not resolve dependencies for project org.apache.cloudstack:cloud-plugin-hypervisor-kvm:jar:4.4.2: Failed to collect dependencies at org.libvirt:libvirt:jar:0.5.1: Failed to read artifact descriptor for org.libvirt:libvirt:jar:0.5.1
After changing the groupid for the one you added, it worked just fine. is that okay if we get this change back ported to 4.3/4.4/4.5, at least?
I can also do that, no problem.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8335: use libvirt from central...
Posted by K0zka <gi...@git.apache.org>.
Github user K0zka closed the pull request at:
https://github.com/apache/cloudstack/pull/163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---