[GitHub] [calcite] rubenada commented on a diff in pull request #3192: [CALCITE-5602] Implement CSC and SEC function

["rubenada (via GitHub)" <gi...@apache.org>]

rubenada commented on code in PR #3192:
URL: https://github.com/apache/calcite/pull/3192#discussion_r1197490985


##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -440,6 +440,8 @@ public enum BuiltInMethod {
   LOG(SqlFunctions.class, "log", long.class, long.class),
   TANH(SqlFunctions.class, "tanh", long.class),
   SINH(SqlFunctions.class, "sinh", long.class),
+  CSC(SqlFunctions.class, "csc", long.class),

Review Comment:
   @zoudan if I am not mistaken, this change in BuiltInMethod is not required: these `CSC` and `SEC` are not used anywhere, so they should be removed to avoid confusion.
   If we check for example a similar PR: https://github.com/apache/calcite/pull/3130 ; in that case BuiltInMethod .java was not impacted, so I think it should be the same in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org