You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/22 01:05:40 UTC

[GitHub] [samza] Zhangyx39 commented on issue #1280: SAMZA-2461: Fix Concurrent Modification Exception in InMemorySystem

Zhangyx39 commented on issue #1280: SAMZA-2461: Fix Concurrent Modification Exception in InMemorySystem
URL: https://github.com/apache/samza/pull/1280#issuecomment-589898386
 
 
   > Looks good to me. Can you add a unit test?
   
   A unit test I can think of is to call poll twice to get two lists. Then try to modify one list and verity that the other list won't be affected. But since we are using immutable list here. The test turns to be testing the immutability of the returned list (expected method not supported exception)...
   Does it sound good to you? Do you have a better idea on this? @mynameborat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services