You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/11/02 13:54:26 UTC
Review Request 63511: Introduced ResourceConversion to represent
conversion to Resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jan Schlicht, and Vinod Kone.
Repository: mesos
Description
-------
Currently, we couple offer operations with resource conversions. For
instance, we have interfaces like `Resources::apply` that takes an
offer operation. This becomes less ideal because an offer operation
might not represent a `conversion` anymore with new offer operation
like `CREATE_VOLUME` being introduced.
This patch decoupled resource conversions from offer operations.
`Resources::apply` will now take a `ResourceConversion` object. We
also provide some helpers to get a `ResourceConversion` from an offer
operation (if supported).
Diffs
-----
include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e
include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441
src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244
src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e
src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c
src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725
Diff: https://reviews.apache.org/r/63511/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 63511: Introduced ResourceConversion to represent
conversion to Resources.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/#review189949
-----------------------------------------------------------
Bad patch!
Reviews applied: [63511, 63485, 63484, 63483, 63482, 63481, 63432, 63480, 63414, 63413, 63213, 63212, 63211, 63210, 63200, 63017, 59989, 59988, 59987, 60109]
Failed command: python support/apply-reviews.py -n -r 59988
Error:
2017-11-02 19:12:00 URL:https://reviews.apache.org/r/59988/diff/raw/ [1148/1148] -> "59988.patch" [1]
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19972/console
- Mesos Reviewbot
On Nov. 2, 2017, 1:54 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63511/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 1:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jan Schlicht, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, we couple offer operations with resource conversions. For
> instance, we have interfaces like `Resources::apply` that takes an
> offer operation. This becomes less ideal because an offer operation
> might not represent a `conversion` anymore with new offer operation
> like `CREATE_VOLUME` being introduced.
>
> This patch decoupled resource conversions from offer operations.
> `Resources::apply` will now take a `ResourceConversion` object. We
> also provide some helpers to get a `ResourceConversion` from an offer
> operation (if supported).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e
> include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441
> src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244
> src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e
> src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c
> src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725
>
>
> Diff: https://reviews.apache.org/r/63511/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 63511: Introduced ResourceConversion to represent
conversion to Resources.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63511/#review189914
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 59988.
Failed command: `python.exe .\support\apply-reviews.py -n -r 59988`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63511
Relevant logs:
- [apply-review-59988-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63511/logs/apply-review-59988-stdout.log):
```
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
```
- Mesos Reviewbot Windows
On Nov. 2, 2017, 6:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63511/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2017, 6:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jan Schlicht, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, we couple offer operations with resource conversions. For
> instance, we have interfaces like `Resources::apply` that takes an
> offer operation. This becomes less ideal because an offer operation
> might not represent a `conversion` anymore with new offer operation
> like `CREATE_VOLUME` being introduced.
>
> This patch decoupled resource conversions from offer operations.
> `Resources::apply` will now take a `ResourceConversion` object. We
> also provide some helpers to get a `ResourceConversion` from an offer
> operation (if supported).
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 53152b393ec38ca2fc2e2a66c18a29a4418fe59e
> include/mesos/v1/resources.hpp 6c2191c044c52607618283891f82401c4861c441
> src/common/resources.cpp 914d3e2b1e8fe55ecab9c71643954addd6a81244
> src/common/resources_utils.hpp 18e3d9d4baad23669d00542594f5c15a989b7b9e
> src/common/resources_utils.cpp e34cd8a3c9046a6f12c12a275a7b3a852b492f4c
> src/v1/resources.cpp 58568b8d25cb1402a875d3975d2decb4270d2725
>
>
> Diff: https://reviews.apache.org/r/63511/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>