You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/11/27 13:33:11 UTC
Review Request 40763: AMBARI-14094 : Remove raise condition in Ranger
KMS start if repo creation fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: AMBARI-14094
https://issues.apache.org/jira/browse/AMBARI-14094
Repository: ambari
Description
-------
Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
Diff: https://reviews.apache.org/r/40763/diff/
Testing
-------
Tested for Start all case and checked for Ranger HA and KMS service start together.
----------------------------------------------------------------------
Ran 271 tests in 8.044s
OK
----------------------------------------------------------------------
Total run:878
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Gautam Borad <gb...@gmail.com>.
> On Nov. 30, 2015, 11 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 282
> > <https://reviews.apache.org/r/40763/diff/1/?file=1147927#file1147927line282>
> >
> > Why the sleep?
> > If there's a timing issue or race condition, we should at least document it in the code.
removed sleep time logic
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/#review108405
-----------------------------------------------------------
On Dec. 1, 2015, 12:16 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40763/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 12:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14094
> https://issues.apache.org/jira/browse/AMBARI-14094
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
> ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
>
> Diff: https://reviews.apache.org/r/40763/diff/
>
>
> Testing
> -------
>
> Tested for Start all case and checked for Ranger HA and KMS service start together.
>
> ----------------------------------------------------------------------
> Ran 271 tests in 8.044s
>
> OK
> ----------------------------------------------------------------------
> Total run:878
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/#review108405
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 282)
<https://reviews.apache.org/r/40763/#comment167872>
Why the sleep?
If there's a timing issue or race condition, we should at least document it in the code.
- Alejandro Fernandez
On Nov. 27, 2015, 12:33 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40763/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 12:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14094
> https://issues.apache.org/jira/browse/AMBARI-14094
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
>
> Diff: https://reviews.apache.org/r/40763/diff/
>
>
> Testing
> -------
>
> Tested for Start all case and checked for Ranger HA and KMS service start together.
>
> ----------------------------------------------------------------------
> Ran 271 tests in 8.044s
>
> OK
> ----------------------------------------------------------------------
> Total run:878
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Gautam Borad <gb...@gmail.com>.
> On Dec. 1, 2015, 3:59 p.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 281
> > <https://reviews.apache.org/r/40763/diff/2/?file=1149601#file1149601line281>
> >
> > Add a delay otherwise the 5 tries might be exhausted too quickly thus not giiving enough time for RangerAdmin to become operational.
Updated in latest patch
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/#review108514
-----------------------------------------------------------
On Dec. 2, 2015, 5:15 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40763/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 5:15 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14094
> https://issues.apache.org/jira/browse/AMBARI-14094
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
> ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
>
> Diff: https://reviews.apache.org/r/40763/diff/
>
>
> Testing
> -------
>
> Tested for Start all case and checked for Ranger HA and KMS service start together.
>
> ----------------------------------------------------------------------
> Ran 271 tests in 8.044s
>
> OK
> ----------------------------------------------------------------------
> Total run:878
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/#review108514
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 281)
<https://reviews.apache.org/r/40763/#comment167967>
Add a delay otherwise the 5 tries might be exhausted too quickly thus not giiving enough time for RangerAdmin to become operational.
- Sebastian Toader
On Dec. 1, 2015, 1:16 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40763/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 1:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14094
> https://issues.apache.org/jira/browse/AMBARI-14094
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
> ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
>
> Diff: https://reviews.apache.org/r/40763/diff/
>
>
> Testing
> -------
>
> Tested for Start all case and checked for Ranger HA and KMS service start together.
>
> ----------------------------------------------------------------------
> Ran 271 tests in 8.044s
>
> OK
> ----------------------------------------------------------------------
> Total run:878
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/#review108618
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Dec. 2, 2015, 6:15 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40763/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 6:15 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-14094
> https://issues.apache.org/jira/browse/AMBARI-14094
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
> ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
> ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
>
> Diff: https://reviews.apache.org/r/40763/diff/
>
>
> Testing
> -------
>
> Tested for Start all case and checked for Ranger HA and KMS service start together.
>
> ----------------------------------------------------------------------
> Ran 271 tests in 8.044s
>
> OK
> ----------------------------------------------------------------------
> Total run:878
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 5:15 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
Changes
-------
Handling Sebastian Toader comment
Bugs: AMBARI-14094
https://issues.apache.org/jira/browse/AMBARI-14094
Repository: ambari
Description
-------
Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
Diff: https://reviews.apache.org/r/40763/diff/
Testing
-------
Tested for Start all case and checked for Ranger HA and KMS service start together.
----------------------------------------------------------------------
Ran 271 tests in 8.044s
OK
----------------------------------------------------------------------
Total run:878
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 40763: AMBARI-14094 : Remove raise condition in
Ranger KMS start if repo creation fails
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40763/
-----------------------------------------------------------
(Updated Dec. 1, 2015, 12:16 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Sebastian Toader, and Velmurugan Periasamy.
Changes
-------
Removed sleep logic and added retry logic
Bugs: AMBARI-14094
https://issues.apache.org/jira/browse/AMBARI-14094
Repository: ambari
Description
-------
Patch contains changes to remove Fail() for Ranger repository creation. Also added 30 seconds sleep time to check for Ranger service.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py 905ec1d
ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 5745c78
ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json d634ce1
Diff: https://reviews.apache.org/r/40763/diff/
Testing
-------
Tested for Start all case and checked for Ranger HA and KMS service start together.
----------------------------------------------------------------------
Ran 271 tests in 8.044s
OK
----------------------------------------------------------------------
Total run:878
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad