You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/12/29 01:32:00 UTC

[jira] [Work logged] (HIVE-26892) Backport HIVE-25243 to 3.2.0: Handle nested values in null struct.

     [ https://issues.apache.org/jira/browse/HIVE-26892?focusedWorklogId=836038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836038 ]

ASF GitHub Bot logged work on HIVE-26892:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Dec/22 01:31
            Start Date: 29/Dec/22 01:31
    Worklog Time Spent: 10m 
      Work Description: cnauroth opened a new pull request, #3898:
URL: https://github.com/apache/hive/pull/3898

   ### What changes were proposed in this pull request?
   
   HIVE-26892: Backport [HIVE-25243](https://issues.apache.org/jira/browse/HIVE-25243) to 3.2.0: Handle nested values in null struct.
   
   This differs from the original patch as follows:
   * There are no changes in `TestJdbcWithMiniLlapVectorArrow`. This file does not exist in branch-3. The original patch was only a whitespace change though.
   * I have not included the new test suite `TestMiniLlapVectorArrowWithLlapIODisabled`. This test suite depends on an additional feature that is only present in master: [HIVE-20300](https://issues.apache.org/jira/browse/HIVE-20300) / https://github.com/apache/hive/commit/a8ef2147fad5aeaaf01279230da9c584db6a2337. This is a fairly large patch that I have not chosen to try backporting at this time.
   
   ### Why are the changes needed?
   
   On branch-3, we've seen a failure in `TestArrowColumnarBatchSerDe` while trying to serialize a row of null values. It fails while trying to serialize the fields of a null struct. This was fixed in 4.0 by [HIVE-25243](https://issues.apache.org/jira/browse/HIVE-25243). This issue tracks a backport to branch-3.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Null structs are now serialized to Arrow format correctly without error.
   
   ### How was this patch tested?
   
   Unfortunately, we are left with no specific new tests as part of this backport. However, I applied this patch locally in combination with [HIVE-26840](https://issues.apache.org/jira/browse/HIVE-26840) / #3859. After that, all tests in `TestArrowColumnarBatchSerDe` are passing.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 836038)
    Remaining Estimate: 0h
            Time Spent: 10m

> Backport HIVE-25243 to 3.2.0: Handle nested values in null struct.
> ------------------------------------------------------------------
>
>                 Key: HIVE-26892
>                 URL: https://issues.apache.org/jira/browse/HIVE-26892
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Serializers/Deserializers
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> On branch-3, we've seen a failure in {{TestArrowColumnarBatchSerDe}} while trying to serialize a row of null values. It fails while trying to serialize the fields of a null struct. This was fixed in 4.0 by HIVE-25243. This issue tracks a backport to branch-3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)