You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Steve Huston <sh...@riverace.com> on 2011/03/08 03:15:47 UTC

Review Request: Allow C++ broker to run as a Windows Service

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/479/
-----------------------------------------------------------

Review request for qpid and Andrew Stitcher.


Summary
-------

Proposed changes to allow the broker to run as a Windows Service. Adds command line options to qpidd to install, uninstall, start, stop the service, as well as the detection that qpidd was started from the service manager and act accordingly (register w/ SCM, default logging to the system event log).


This addresses bug QPID-2519.
    https://issues.apache.org/jira/browse/QPID-2519


Diffs
-----

  /branches/QPID-2519/cpp/src/CMakeLists.txt 1072051 
  /branches/QPID-2519/cpp/src/posix/QpiddBroker.cpp 1072051 
  /branches/QPID-2519/cpp/src/qpidd.h 1072051 
  /branches/QPID-2519/cpp/src/qpidd.cpp 1072051 
  /branches/QPID-2519/cpp/src/windows/QpiddBroker.cpp 1072051 
  /branches/QPID-2519/cpp/src/windows/SCM.h PRE-CREATION 
  /branches/QPID-2519/cpp/src/windows/SCM.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/479/diff


Testing
-------

Basic install, uninstall, start, stop. Has a problem running as LocalService that I don't yet know the cause of.


Thanks,

Steve

Re: Review Request: Allow C++ broker to run as a Windows Service

Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/479/#review314
-----------------------------------------------------------


Nothing leaps out as an obvious issue here. Although I think the SCM class should probably in qpid/sys/windows as it seems to implement a platform specific functionality rather than be a necessary windows variant of existing code.

We are working towards no platform variants of the existing code and all platform specific code in qpid/sys/[posix|windows|...] with platform variances abstracted through different interface implementations.

- Andrew


On 2011-03-07 18:15:46, Steve Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/479/
> -----------------------------------------------------------
> 
> (Updated 2011-03-07 18:15:46)
> 
> 
> Review request for qpid and Andrew Stitcher.
> 
> 
> Summary
> -------
> 
> Proposed changes to allow the broker to run as a Windows Service. Adds command line options to qpidd to install, uninstall, start, stop the service, as well as the detection that qpidd was started from the service manager and act accordingly (register w/ SCM, default logging to the system event log).
> 
> 
> This addresses bug QPID-2519.
>     https://issues.apache.org/jira/browse/QPID-2519
> 
> 
> Diffs
> -----
> 
>   /branches/QPID-2519/cpp/src/CMakeLists.txt 1072051 
>   /branches/QPID-2519/cpp/src/posix/QpiddBroker.cpp 1072051 
>   /branches/QPID-2519/cpp/src/qpidd.h 1072051 
>   /branches/QPID-2519/cpp/src/qpidd.cpp 1072051 
>   /branches/QPID-2519/cpp/src/windows/QpiddBroker.cpp 1072051 
>   /branches/QPID-2519/cpp/src/windows/SCM.h PRE-CREATION 
>   /branches/QPID-2519/cpp/src/windows/SCM.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/479/diff
> 
> 
> Testing
> -------
> 
> Basic install, uninstall, start, stop. Has a problem running as LocalService that I don't yet know the cause of.
> 
> 
> Thanks,
> 
> Steve
> 
>