[GitHub] [incubator-superset] MarcusSorealheis edited a comment on issue #7502: Keep Search button because previously it disappeared + formatting.

[GitBox <gi...@apache.org>]

MarcusSorealheis edited a comment on issue #7502: Keep Search button because previously it disappeared + formatting.
URL: https://github.com/apache/incubator-superset/pull/7502#issuecomment-492345703
 
 
   Old State:
   
   When you add filters:
   <img width="1254" alt="With fliters" src="https://user-images.githubusercontent.com/2353608/57720615-1048dc00-7637-11e9-9e43-bd7e2c7df778.png">
   
   When you clear those filters, as you can see in the screenshot below you are stuck with a filtered list of tables:
   <img width="1257" alt="with filters cleared" src="https://user-images.githubusercontent.com/2353608/57720625-19d24400-7637-11e9-97bc-3fb810fb5466.png">
   
   In the current state the only way to render an unfiltered list of list of tables is to refresh the page, which would be step 3 but I am omitting because it would require a refresh and I'm trying to draw the distinction. That's unintuitive to some business users. Since the cursor is already there, it would be better if they could simply refresh with the same button. One could argue that clearing filters prompts a refresh, but if you have as many tables as we do, you don't want to do that unless you want to do that if you catch my drift. 
   
   So, here's the new version from this PR:
   
   start with a filter:
   <img width="1237" alt="Screen Shot 2019-05-14 at 10 54 14 AM" src="https://user-images.githubusercontent.com/2353608/57720798-76356380-7637-11e9-8d6c-7d6f2a6f8381.png">
   
   Clear the filter and you still have control (see new button)
   <img width="1251" alt="Screen Shot 2019-05-14 at 10 54 23 AM" src="https://user-images.githubusercontent.com/2353608/57720874-9ebd5d80-7637-11e9-883e-c917f46ee2ec.png">
   
   And after clicking the refresh button (you get unfiltered results)
   
   <img width="1260" alt="Screen Shot 2019-05-14 at 10 54 31 AM" src="https://user-images.githubusercontent.com/2353608/57720993-ea700700-7637-11e9-8b6c-5b76dafeb685.png">
   :
   
   Let me know if this makes sense.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org