You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by davidyan74 <gi...@git.apache.org> on 2016/04/08 00:56:44 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-423 style fix for apex-...
GitHub user davidyan74 opened a pull request:
https://github.com/apache/incubator-apex-core/pull/299
APEXCORE-423 style fix for apex-core engine
@chandnisingh please merge. thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davidyan74/incubator-apex-core style
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit c92371a440701573e0ed1a9d6a181205f64a8ab8
Author: CI Support <je...@datatorrent.com>
Date: 2016-04-06T22:02:26Z
APEXCORE-423 style fix for apex-core engine
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-423 style fix for apex-...
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/299#issuecomment-207715549
@davidyan74 a test is failing. not related I guess?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-423 style fix for apex-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-423 style fix for apex-...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/299#issuecomment-207718664
Tests pass locally. I have already merged the PR, but it still does not show up in the mirror.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-423 style fix for apex-...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/299#issuecomment-207198083
Please hold this PR until Fri afternoon. It probably means everyone else will have to rebase and resolve merge conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---