[GitHub] [bigtop] iwasakims commented on pull request #855: BIGTOP-3632: Bump elasticsearch's log4j dependencies to 2.17.0

[GitBox <gi...@apache.org>]

iwasakims commented on pull request #855:
URL: https://github.com/apache/bigtop/pull/855#issuecomment-1017585965


   Thanks for working on this, @yoda-mon. Could you update bigtop-packages/src/rpm/elasticsearch/SPECS/elasticsearch.spec too? like
   
   ```
   $ git diff
   diff --git a/bigtop-packages/src/rpm/elasticsearch/SPECS/elasticsearch.spec b/bigtop-packages/src/rpm/elasticsearch/SPECS/elasticsearch.spec
   index c7f94f87..f3619375 100644
   --- a/bigtop-packages/src/rpm/elasticsearch/SPECS/elasticsearch.spec
   +++ b/bigtop-packages/src/rpm/elasticsearch/SPECS/elasticsearch.spec
   @@ -53,6 +53,7 @@ Source1: do-component-build
    Source2: install_%{name}.sh
    Source3: elasticsearch.default
    Source4: elasticsearch.init
   +#BIGTOP_PATCH_FILES
    Requires: bigtop-utils >= 0.7
   
    # CentOS 5 does not have any dist macro
   @@ -71,6 +72,8 @@ an HTTP web interface and schema-free JSON documents.
    %prep
    %setup -n elasticsearch-%{elasticsearch_base_version}
   
   +#BIGTOP_PATCH_COMMAND
   +
    %build
    env FULL_VERSION=%{elasticsearch_base_version} bash %{SOURCE1}
   ```
   
   The patch0-log4j2-2.17.0.diff is not applied without those lines for rpm packaging.
   
   ```
   $ rpm -qlp output/elasticsearch/noarch/elasticsearch-5.6.14-2.el8.noarch.rpm | grep log4j
   /etc/elasticsearch/conf.dist/log4j2.properties
   /usr/lib/elasticsearch/lib/log4j-1.2-api-2.11.1.jar
   /usr/lib/elasticsearch/lib/log4j-api-2.11.1.jar
   /usr/lib/elasticsearch/lib/log4j-core-2.11.1.jar
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org