[jira] [Comment Edited] (YARN-5219) When an export var command fails in launch_container.sh, the full container launch should fail

["Suma Shivaprasad (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096740#comment-16096740 ] 

Suma Shivaprasad edited comment on YARN-5219 at 7/21/17 9:03 PM:
-----------------------------------------------------------------

1. Could enable "set +o pipefail -e" to capture exitCode of the failed command in a given command pipeline - the exit status of a pipeline is the exit status of the last command in the pipeline,  if the pipefail option is disabled which is the default -  https://www.gnu.org/software/bash/manual/html_node/Pipelines.html

2. Could rename setEnvValidator function to setExitOnFailure 



was (Author: suma.shivaprasad):
Could enable "set +o pipefail -e" to capture exitCode of the failed command in a given command pipeline - the exit status of a pipeline is the exit status of the last command in the pipeline,  if the pipefail option is disabled which is the default -  https://www.gnu.org/software/bash/manual/html_node/Pipelines.html

> When an export var command fails in launch_container.sh, the full container launch should fail
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-5219
>                 URL: https://issues.apache.org/jira/browse/YARN-5219
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Hitesh Shah
>            Assignee: Sunil G
>         Attachments: YARN-5219.001.patch, YARN-5219.003.patch, YARN-5219.004.patch, YARN-5219.005.patch, YARN-5219.006.patch, YARN-5219-branch-2.001.patch
>
>
> Today, a container fails if certain files fail to localize. However, if certain env vars fail to get setup properly either due to bugs in the yarn application or misconfiguration, the actual process launch still gets triggered. This results in either confusing error messages if the process fails to launch or worse yet the process launches but then starts behaving wrongly if the env var is used to control some behavioral aspects. 
> In this scenario, the issue was reproduced by trying to do export abc="$\{foo.bar}" which is invalid as var names cannot contain "." in bash. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org