You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Eric Sammer <es...@cloudera.com> on 2011/12/22 21:45:50 UTC
Review Request: FLUME-894: Add log4j as part of the build
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3295/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Made log4j a dep so it's included in the resultant artifact.
This addresses bug FLUME-894.
https://issues.apache.org/jira/browse/FLUME-894
Diffs
-----
i/flume-ng-node/pom.xml a70cf26
Diff: https://reviews.apache.org/r/3295/diff
Testing
-------
Thanks,
Eric
Re: Review Request: FLUME-894: Add log4j as part of the build
Posted by Arvind Prabhakar <ar...@apache.org>.
> On 2011-12-22 21:31:15, Arvind Prabhakar wrote:
> > +1
> >
> > Don't we need to also add the log4j bindings for slf4j dependency?
Ignore my comment - I see it is already there.
- Arvind
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3295/#review4086
-----------------------------------------------------------
On 2011-12-22 20:45:50, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3295/
> -----------------------------------------------------------
>
> (Updated 2011-12-22 20:45:50)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Made log4j a dep so it's included in the resultant artifact.
>
>
> This addresses bug FLUME-894.
> https://issues.apache.org/jira/browse/FLUME-894
>
>
> Diffs
> -----
>
> i/flume-ng-node/pom.xml a70cf26
>
> Diff: https://reviews.apache.org/r/3295/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>
Re: Review Request: FLUME-894: Add log4j as part of the build
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3295/#review4086
-----------------------------------------------------------
Ship it!
+1
Don't we need to also add the log4j bindings for slf4j dependency?
- Arvind
On 2011-12-22 20:45:50, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3295/
> -----------------------------------------------------------
>
> (Updated 2011-12-22 20:45:50)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Made log4j a dep so it's included in the resultant artifact.
>
>
> This addresses bug FLUME-894.
> https://issues.apache.org/jira/browse/FLUME-894
>
>
> Diffs
> -----
>
> i/flume-ng-node/pom.xml a70cf26
>
> Diff: https://reviews.apache.org/r/3295/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Eric
>
>