You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@marmotta.apache.org by Fabian Christ <ch...@googlemail.com> on 2013/03/15 09:33:03 UTC

Checking source release candidate (was Re: release preparation)

2013/3/14 Sebastian Schaffert <ss...@apache.org>:
> Uploading a new version. It is again available at
>
> http://people.apache.org/~sschaffert/3.0.0-incubating-SNAPSHOT/

I downloaded the latest apache-marmotta-3.0.0-incubating-SNAPSHOT-src.tar.gz

- Imported KEYS - verification okay
- NOTICE.txt
The NOTICE file is meant to contain additional notices for included
third party sources whose licenses require such a notice. Now, there
are some notices in the NOTICE.txt like this one "software based on
IzPack licensed under Apache License 2.0". I think, for Apache
licensed code this is not needed. On the other hand, some BSD licensed
code requires a notice. You should have a look at the exact license
text to find out what exactly should be mentioned as a notice.

- LICENSE.txt
Just pointing to a URL for license details is not enough, like "For
details, see https://github.com/tristan/jsonld-java". The idea of the
LICENSE file is to have all the license information included without
the need to have to look anywhere else. So please, include the
original license texts there.

That's it for the moment. I continue building Marmotta and provide
more comments when the time allows it.

Best,
 - Fabian
--
Fabian
http://twitter.com/fctwitt

Re: Checking source release candidate (was Re: release preparation)

Posted by Sebastian Schaffert <se...@gmail.com>.
Hi Fabian,


2013/3/15 Fabian Christ <ch...@googlemail.com>

> 2013/3/15 Sebastian Schaffert <se...@gmail.com>:
> > Only the BSD code licensed under the old (original) BSD license with
> > advertisement clause requires such notice (see
> > http://www.apache.org/dev/licensing-howto.html). All code we included is
> > published under the New BSD license without advertisement clause, so they
> > are not added to NOTICE. Is this incorrect?
>
> I think its correct. So are there any notices beside the default one
> required at all for the source release?
>

I was not sure of that so I kept the pointers to the 3rd party source files
bundled in the source distribution, just to be sure. But according to the
licensing howto, it is probably not needed, and according to that howto the
NOTICE file should be reduced to the absolute minimum that is necessary.


>
> > I copied this over from
> >
> > http://www.apache.org/dev/licensing-howto.html
> >
> > (Bundling Permissively Licensed Dependencies)
> >
> > where it says that for MIT license and for 3-clause BSD (i.e. without
> > advertisement, or "New BSD") the pointer is sufficient. How did you
> handle
> > this in your projects?
>
> Was not aware of that, thanks! I always thought that you need the
> original license text without any exceptions. So, in this case I think
> you are fine. Cool :)
>

;-)

Sebastian

Re: Checking source release candidate (was Re: release preparation)

Posted by Fabian Christ <ch...@googlemail.com>.
2013/3/15 Sebastian Schaffert <se...@gmail.com>:
> Only the BSD code licensed under the old (original) BSD license with
> advertisement clause requires such notice (see
> http://www.apache.org/dev/licensing-howto.html). All code we included is
> published under the New BSD license without advertisement clause, so they
> are not added to NOTICE. Is this incorrect?

I think its correct. So are there any notices beside the default one
required at all for the source release?

> I copied this over from
>
> http://www.apache.org/dev/licensing-howto.html
>
> (Bundling Permissively Licensed Dependencies)
>
> where it says that for MIT license and for 3-clause BSD (i.e. without
> advertisement, or "New BSD") the pointer is sufficient. How did you handle
> this in your projects?

Was not aware of that, thanks! I always thought that you need the
original license text without any exceptions. So, in this case I think
you are fine. Cool :)


-- 
Fabian
http://twitter.com/fctwitt

Re: Checking source release candidate (was Re: release preparation)

Posted by Sebastian Schaffert <se...@gmail.com>.
Hi Fabian,

thanks for the check!


2013/3/15 Fabian Christ <ch...@googlemail.com>

> 2013/3/14 Sebastian Schaffert <ss...@apache.org>:
> > Uploading a new version. It is again available at
> >
> > http://people.apache.org/~sschaffert/3.0.0-incubating-SNAPSHOT/
>
> I downloaded the latest
> apache-marmotta-3.0.0-incubating-SNAPSHOT-src.tar.gz
>
> - Imported KEYS - verification okay
> - NOTICE.txt
> The NOTICE file is meant to contain additional notices for included
> third party sources whose licenses require such a notice. Now, there
> are some notices in the NOTICE.txt like this one "software based on
> IzPack licensed under Apache License 2.0". I think, for Apache
> licensed code this is not needed. On the other hand, some BSD licensed
> code requires a notice. You should have a look at the exact license
> text to find out what exactly should be mentioned as a notice.
>

Only the BSD code licensed under the old (original) BSD license with
advertisement clause requires such notice (see
http://www.apache.org/dev/licensing-howto.html). All code we included is
published under the New BSD license without advertisement clause, so they
are not added to NOTICE. Is this incorrect?


>
> - LICENSE.txt
> Just pointing to a URL for license details is not enough, like "For
> details, see https://github.com/tristan/jsonld-java". The idea of the
> LICENSE file is to have all the license information included without
> the need to have to look anywhere else. So please, include the
> original license texts there.
>


I copied this over from

http://www.apache.org/dev/licensing-howto.html

(Bundling Permissively Licensed Dependencies)

where it says that for MIT license and for 3-clause BSD (i.e. without
advertisement, or "New BSD") the pointer is sufficient. How did you handle
this in your projects?


>
> That's it for the moment. I continue building Marmotta and provide
> more comments when the time allows it.
>
> Best,
>  - Fabian
> --
> Fabian
> http://twitter.com/fctwitt
>

Re: Checking source release candidate (was Re: release preparation)

Posted by Fabian Christ <ch...@googlemail.com>.
2013/3/15 Sebastian Schaffert <se...@gmail.com>:
> Facebook returns different data depending on the IP address and
> country the request comes from.

FYI, I am currently in Luxemburg when I executed the test ;)


-- 
Fabian
http://twitter.com/fctwitt

Re: Checking source release candidate (was Re: release preparation)

Posted by Sebastian Schaffert <se...@gmail.com>.
Hi Fabian and Andy,

I found the problem you are experiencing with the Facebook Test.
Apparently, Facebook returns different data depending on the IP address and
country the request comes from. I just checked:
- a request for http://graph.facebook.com/106515832719603 from Germany or
Austria returns "Berg"
- a request for http://graph.facebook.com/106515832719603 from
people.apache.org (probably US) returns "Mountains"

WTF. I will have to think a bit about this and disable the test in the
meantime. Thanks for the patience and testing, looking forward to the
Jenkins server already ... :)

Greetings,

Sebastian


2013/3/15 Sebastian Schaffert <se...@gmail.com>

> Hi Fabian,
>
>
> 2013/3/15 Fabian Christ <ch...@googlemail.com>
>
>> 2013/3/15 Sebastian Schaffert <se...@gmail.com>:
>> > The problem
>> > is that this test queries the Facebook Web Service, so it is unreliable
>> and
>> > dependent on network connection and service availability.
>>
>> My internet connection works fine. No idea why this is not working.
>> Instead of disabling you could make the test not fail in cases of
>> connection problems. I imagine you do not want to test the connection
>> itself but more test exchanged data, right?
>>
>
> We already have that connection test but I forgot enabling it for this
> test. It might work now.
>
> Testing the exchanged data is one part, but I'd also like the test to fail
> in case Facebook decides they change the data structures they return, so it
> is worthwhile testing also the webservice. Also, the Facebook Terms of
> Service do not allow storing their data locally...
>
> Anyways, if it is not working, we can simply disable the test for the
> build. It is non-critical and unlikely to fail if someone changes code in
> some other location (because it has almost no dependencies).
>
> Greetings,
>
> Sebastian
>
>

Re: Checking source release candidate (was Re: release preparation)

Posted by Sebastian Schaffert <se...@gmail.com>.
Hi Fabian,


2013/3/15 Fabian Christ <ch...@googlemail.com>

> 2013/3/15 Sebastian Schaffert <se...@gmail.com>:
> > The problem
> > is that this test queries the Facebook Web Service, so it is unreliable
> and
> > dependent on network connection and service availability.
>
> My internet connection works fine. No idea why this is not working.
> Instead of disabling you could make the test not fail in cases of
> connection problems. I imagine you do not want to test the connection
> itself but more test exchanged data, right?
>

We already have that connection test but I forgot enabling it for this
test. It might work now.

Testing the exchanged data is one part, but I'd also like the test to fail
in case Facebook decides they change the data structures they return, so it
is worthwhile testing also the webservice. Also, the Facebook Terms of
Service do not allow storing their data locally...

Anyways, if it is not working, we can simply disable the test for the
build. It is non-critical and unlikely to fail if someone changes code in
some other location (because it has almost no dependencies).

Greetings,

Sebastian

Re: Checking source release candidate (was Re: release preparation)

Posted by Fabian Christ <ch...@googlemail.com>.
2013/3/15 Sebastian Schaffert <se...@gmail.com>:
> The problem
> is that this test queries the Facebook Web Service, so it is unreliable and
> dependent on network connection and service availability.

My internet connection works fine. No idea why this is not working.
Instead of disabling you could make the test not fail in cases of
connection problems. I imagine you do not want to test the connection
itself but more test exchanged data, right?


-- 
Fabian
http://twitter.com/fctwitt

Re: Checking source release candidate (was Re: release preparation)

Posted by Sebastian Schaffert <se...@gmail.com>.
Hi Fabian,

strange that this happens for Andy and you but for none of us. The problem
is that this test queries the Facebook Web Service, so it is unreliable and
dependent on network connection and service availability. I will simply
disable it.

Another problem is that we did not yet get a Jenkins account for
automatically running tests, so we are a bit dependent on our
infrastructure for testing.

Greetings,

Sebastian


2013/3/15 Fabian Christ <ch...@googlemail.com>

> 2013/3/15 Fabian Christ <ch...@googlemail.com>:
> > I continue building Marmotta and provide
> > more comments when the time allows it.
>
> The build failed for me at
>
> LDClient Provider: Facebook Graph
>
>
> testInterest(org.apache.marmotta.ldclient.test.facebook.FacebookProviderTest)
>  Time elapsed: 0.217 sec  <<< FAILURE!
> java.lang.AssertionError: SPARQL test query failed
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at
> org.apache.marmotta.ldclient.test.facebook.FacebookProviderTest.testInterest(FacebookProviderTest.java:83)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> at
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
>
> Used environment:
> Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: /opt/apache-maven-3.0.4
> Java version: 1.6.0_26, vendor: Sun Microsystems Inc.
> Java home: /usr/lib/jvm/java-6-sun-1.6.0.26/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.0.0-17-generic", arch: "i386", family: "unix"
>
> --
> Fabian
> http://twitter.com/fctwitt
>

Re: Checking source release candidate (was Re: release preparation)

Posted by Fabian Christ <ch...@googlemail.com>.
2013/3/15 Fabian Christ <ch...@googlemail.com>:
> I continue building Marmotta and provide
> more comments when the time allows it.

The build failed for me at

LDClient Provider: Facebook Graph

testInterest(org.apache.marmotta.ldclient.test.facebook.FacebookProviderTest)
 Time elapsed: 0.217 sec  <<< FAILURE!
java.lang.AssertionError: SPARQL test query failed
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.apache.marmotta.ldclient.test.facebook.FacebookProviderTest.testInterest(FacebookProviderTest.java:83)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)

Used environment:
Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
Maven home: /opt/apache-maven-3.0.4
Java version: 1.6.0_26, vendor: Sun Microsystems Inc.
Java home: /usr/lib/jvm/java-6-sun-1.6.0.26/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.0.0-17-generic", arch: "i386", family: "unix"

--
Fabian
http://twitter.com/fctwitt