You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by rodrigo meneses <rm...@pivotal.io> on 2014/10/03 21:22:57 UTC
Review Request 26322: Mahout Service with Bigtop Stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/
-----------------------------------------------------------
Review request for Ambari and jun aoki.
Repository: ambari
Description
-------
Support for Mahout Service with Bigtop Stack
Diffs
-----
ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/26322/diff/
Testing
-------
1. Deployed Bigtop stack w/ Mahout Service
2. Passed all Mahout smoke tests: run mahout recommenditembas command
Thanks,
rodrigo meneses
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/#review55724
-----------------------------------------------------------
File Attachment: Mahout support Patch - AMBARI-7551.v2.patch
<https://reviews.apache.org//r/26322/#fcomment30>
Please update the patch on the review in order to compare against v1.
- Alejandro Fernandez
On Oct. 7, 2014, 10:28 p.m., rodrigo meneses wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26322/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 10:28 p.m.)
>
>
> Review request for Ambari and jun aoki.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support for Mahout Service with Bigtop Stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26322/diff/
>
>
> Testing
> -------
>
> 1. Deployed Bigtop stack w/ Mahout Service
> 2. Passed all Mahout smoke tests: run mahout recommenditembas command
>
>
> File Attachments
> ----------------
>
> Mahout support Patch
> https://reviews.apache.org/media/uploaded/files/2014/10/07/585eca9a-492d-4733-be06-694e7b29e3c1__AMBARI-7551.v2.patch
>
>
> Thanks,
>
> rodrigo meneses
>
>
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/#review55734
-----------------------------------------------------------
Ship it!
Ship It!
- jun aoki
On Oct. 7, 2014, 11:49 p.m., rodrigo meneses wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26322/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 11:49 p.m.)
>
>
> Review request for Ambari and jun aoki.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support for Mahout Service with Bigtop Stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26322/diff/
>
>
> Testing
> -------
>
> 1. Deployed Bigtop stack w/ Mahout Service
> 2. Passed all Mahout smoke tests: run mahout recommenditembas command
>
>
> Thanks,
>
> rodrigo meneses
>
>
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/#review55741
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 7, 2014, 11:49 p.m., rodrigo meneses wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26322/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 11:49 p.m.)
>
>
> Review request for Ambari and jun aoki.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support for Mahout Service with Bigtop Stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26322/diff/
>
>
> Testing
> -------
>
> 1. Deployed Bigtop stack w/ Mahout Service
> 2. Passed all Mahout smoke tests: run mahout recommenditembas command
>
>
> Thanks,
>
> rodrigo meneses
>
>
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by rodrigo meneses <rm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 11:49 p.m.)
Review request for Ambari and jun aoki.
Repository: ambari
Description
-------
Support for Mahout Service with Bigtop Stack
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/26322/diff/
Testing
-------
1. Deployed Bigtop stack w/ Mahout Service
2. Passed all Mahout smoke tests: run mahout recommenditembas command
Thanks,
rodrigo meneses
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by rodrigo meneses <rm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 11:48 p.m.)
Review request for Ambari and jun aoki.
Repository: ambari
Description
-------
Support for Mahout Service with Bigtop Stack
Diffs
-----
ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/26322/diff/
Testing
-------
1. Deployed Bigtop stack w/ Mahout Service
2. Passed all Mahout smoke tests: run mahout recommenditembas command
Thanks,
rodrigo meneses
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by rodrigo meneses <rm...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/
-----------------------------------------------------------
(Updated Oct. 7, 2014, 10:28 p.m.)
Review request for Ambari and jun aoki.
Repository: ambari
Description
-------
Support for Mahout Service with Bigtop Stack
Diffs
-----
ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/26322/diff/
Testing
-------
1. Deployed Bigtop stack w/ Mahout Service
2. Passed all Mahout smoke tests: run mahout recommenditembas command
File Attachments (updated)
----------------
Mahout support Patch
https://reviews.apache.org/media/uploaded/files/2014/10/07/585eca9a-492d-4733-be06-694e7b29e3c1__AMBARI-7551.v2.patch
Thanks,
rodrigo meneses
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/#review55421
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py
<https://reviews.apache.org/r/26322/#comment95778>
This is not a big deal, but writing
"if params.log4j_props:"
or even
"if params.log4j_props is not None:"
is more Pythonic
Also, you can skip the parantheses in the "if" statement unless the clauses really require an order of precedence.
ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py
<https://reviews.apache.org/r/26322/#comment95779>
Why use triple quoted string when it's basically a single line?
- Alejandro Fernandez
On Oct. 3, 2014, 7:22 p.m., rodrigo meneses wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26322/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 7:22 p.m.)
>
>
> Review request for Ambari and jun aoki.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support for Mahout Service with Bigtop Stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26322/diff/
>
>
> Testing
> -------
>
> 1. Deployed Bigtop stack w/ Mahout Service
> 2. Passed all Mahout smoke tests: run mahout recommenditembas command
>
>
> Thanks,
>
> rodrigo meneses
>
>
Re: Review Request 26322: Mahout Service with Bigtop Stack
Posted by Judes Sarmiento <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26322/#review55387
-----------------------------------------------------------
Ship it!
Ship It!
- Judes Sarmiento
On Oct. 3, 2014, 7:22 p.m., rodrigo meneses wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26322/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 7:22 p.m.)
>
>
> Review request for Ambari and jun aoki.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Support for Mahout Service with Bigtop Stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/role_command_order.json 2604b6d
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/metainfo.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/mahout_client.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/params.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/scripts/service_check.py PRE-CREATION
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/MAHOUT/package/templates/mahout-env.sh.j2 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26322/diff/
>
>
> Testing
> -------
>
> 1. Deployed Bigtop stack w/ Mahout Service
> 2. Passed all Mahout smoke tests: run mahout recommenditembas command
>
>
> Thanks,
>
> rodrigo meneses
>
>