You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "Tomaz Muraus (JIRA)" <ji...@apache.org> on 2013/08/29 16:24:52 UTC
[jira] [Comment Edited] (LIBCLOUD-388) deploy_node not supported in
cloudstack driver
[ https://issues.apache.org/jira/browse/LIBCLOUD-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753660#comment-13753660 ]
Tomaz Muraus edited comment on LIBCLOUD-388 at 8/29/13 2:23 PM:
----------------------------------------------------------------
Just FYI, tests failed under 3.2 and 3.3.
{quote}
======================================================================
ERROR: test_list_nodes_response (libcloud.test.compute.test_cloudstack.CloudStackNodeDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/w/lc/libcloud/libcloud/test/compute/__init__.py", line 26, in test_list_nodes_response
nodes = self.driver.list_nodes()
File "/w/lc/libcloud/libcloud/compute/drivers/cloudstack.py", line 259, in list_nodes
public_ips.extend([ip for ip in private_ips
AttributeError: 'dict_keys' object has no attribute 'extend'
...
{quote}
This time I've fixed it (https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=commitdiff;h=260e305d2f7516a65423f31b3795d777c3af87ba), but next time please run "tox" before submitting a final patch and make sure all the tests pass.
There were also a bunch of issues with the documentation which I have also fixed (https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=commitdiff;h=b6fa496d7010938519e6fdecdbbf60674e7d9321 ):
- some text was out of date
- Issues with example code (undefined IMAGE_ID, extra_args was used in a wrong way, unused TEMPLATE_ID, ..).
was (Author: kami):
Just FYI, tests failed under 3.2 and 3.3.
{quote}
======================================================================
ERROR: test_list_nodes_response (libcloud.test.compute.test_cloudstack.CloudStackNodeDriverTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/w/lc/libcloud/libcloud/test/compute/__init__.py", line 26, in test_list_nodes_response
nodes = self.driver.list_nodes()
File "/w/lc/libcloud/libcloud/compute/drivers/cloudstack.py", line 259, in list_nodes
public_ips.extend([ip for ip in private_ips
AttributeError: 'dict_keys' object has no attribute 'extend'
...
{quote}
This time I've fixed it (https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=commitdiff;h=260e305d2f7516a65423f31b3795d777c3af87ba), but next time please run "tox" before submitting a final patch and make sure all the tests pass.
There were also a bunch of issues with the documentation which I have also fixed (https://git-wip-us.apache.org/repos/asf?p=libcloud.git;a=commitdiff;h=b6fa496d7010938519e6fdecdbbf60674e7d9321):
- some text was out of date
- Issues with example code (undefined IMAGE_ID, extra_args was used in a wrong way, unused TEMPLATE_ID, ..).
> deploy_node not supported in cloudstack driver
> ----------------------------------------------
>
> Key: LIBCLOUD-388
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-388
> Project: Libcloud
> Issue Type: Bug
> Components: Compute
> Affects Versions: 0.12.3
> Reporter: sebastien goasguen
> Attachments: libcloud388.patch
>
>
> deploy_node not available due to lack of auth
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira