You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/08/09 17:50:42 UTC
[PR] site: reorganize navbar so that "community" is top level [iceberg]
kevinjqliu opened a new pull request, #13774:
URL: https://github.com/apache/iceberg/pull/13774
Closes #13261
Preview:
<img width="1347" height="495" alt="Screenshot 2025-08-09 at 10 49 55 AM" src="https://github.com/user-attachments/assets/2615b22e-3ce9-4212-83d5-ac44ad9356c8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3172946596
> Do you know if this breaks existing links?
nope, it does not break existing links on the iceberg website
These are the 4 changes:
```
- Blogs: blogs.md
- Talks: talks.md
- Vendors: vendors.md
- Project:
- Community: community.md
```
which currently maps to
https://iceberg.apache.org/blogs/
https://iceberg.apache.org/talks/
https://iceberg.apache.org/vendors/
https://iceberg.apache.org/community/
and i double checked locally and its still the same link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #13774:
URL: https://github.com/apache/iceberg/pull/13774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#discussion_r2265515984
##########
site/nav.yml:
##########
@@ -63,6 +59,12 @@ nav:
- License: https://www.apache.org/licenses/
- Security: https://www.apache.org/security/
- Sponsors: https://www.apache.org/foundation/sponsors.html
+ - Community:
+ - Community: community.md
+ - Community Content:
Review Comment:
I don't think we need this subsection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3180479162
now live!
<img width="1502" height="682" alt="Screenshot 2025-08-12 at 11 18 00 AM" src="https://github.com/user-attachments/assets/85c9261c-7334-4364-ab09-01b6e8f46ec8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3175922142
@kevinjqliu The left nav is a bit awkward. We have three community sections: (community, community, community content)
Maybe we need to drop the top header and just have: Contributing, Blogs, Talks, Vendors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3176141179
Updated!
I also ran it locally and included preview for both the "Project" and "Community" section. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3180461877
thanks for the review everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#discussion_r2267346931
##########
site/nav.yml:
##########
@@ -63,6 +59,12 @@ nav:
- License: https://www.apache.org/licenses/
- Security: https://www.apache.org/security/
- Sponsors: https://www.apache.org/foundation/sponsors.html
+ - Community:
+ - Community: community.md
+ - Community Content:
Review Comment:
i like the separation between "community", "content" and "vendors". See the preview screenshot.
I could take it out too, dont have strong preference either way :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3172904302
Thanks @kevinjqliu, and I like the re-ordering of content. Do you know if this breaks existing links?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3181995167
Just noticed several links in the Community footer is broken. Submitted https://github.com/apache/iceberg/pull/13796 to fix. Please help review @kevinjqliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] site: reorganize navbar so that "community" is top level [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #13774:
URL: https://github.com/apache/iceberg/pull/13774#issuecomment-3176026216
sg manu had the same feedback, i'll make the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org