[jira] [Commented] (CALCITE-4992) RestClient resource leak in ElasticSearch adapter

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521375#comment-17521375 ] 

Julian Hyde commented on CALCITE-4992:
--------------------------------------

[~dzamo], With your recent changes, the PR looks good. I'm going to change the commit message to 'RestClient resource leak in Elasticsearch adapter' (note lower-case 's') and merge.

> RestClient resource leak in ElasticSearch adapter
> -------------------------------------------------
>
>                 Key: CALCITE-4992
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4992
>             Project: Calcite
>          Issue Type: Bug
>          Components: elasticsearch-adapter
>    Affects Versions: 1.29.0
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.31.0
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> RestClient instances should receive a `close()`call at the end of their lifecyle, as documented here.
> [https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-low-usage-initialization.html]
> We have monitored file descriptor leaks on systems running Apache Drill and have come to believe (but not proven) that they are associated with Drill's ElasticSearch plugin, and that in turn makes use of Calcite's ElasticSearch adapter.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)