You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2011/06/10 18:27:30 UTC
Review Request: QPID-3200: cumulative acknowledgement up to a specified point
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/
-----------------------------------------------------------
Review request for qpid.
Summary
-------
This patch adds a new method to the qpid::messaging::Session class in the public API that allows all messages up to a certain point to be acknowledged.
This addresses bug QPID-3200.
https://issues.apache.org/jira/browse/QPID-3200
Diffs
-----
/trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102
/trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822
/trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102
Diff: https://reviews.apache.org/r/882/diff
Testing
-------
All existing tests pass, new test added to cover the new method.
Thanks,
Gordon
Re: Review Request: QPID-3200: cumulative acknowledgement up to a specified
point
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review831
-----------------------------------------------------------
Ship it!
- Alan
On 2011-06-10 16:27:29, Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/882/
> -----------------------------------------------------------
>
> (Updated 2011-06-10 16:27:29)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This patch adds a new method to the qpid::messaging::Session class in the public API that allows all messages up to a certain point to be acknowledged.
>
>
> This addresses bug QPID-3200.
> https://issues.apache.org/jira/browse/QPID-3200
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822
> /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102
>
> Diff: https://reviews.apache.org/r/882/diff
>
>
> Testing
> -------
>
> All existing tests pass, new test added to cover the new method.
>
>
> Thanks,
>
> Gordon
>
>
Re: Review Request: QPID-3200: cumulative acknowledgement up to a specified
point
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/882/#review832
-----------------------------------------------------------
Ship it!
- Kenneth
On 2011-06-10 16:27:29, Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/882/
> -----------------------------------------------------------
>
> (Updated 2011-06-10 16:27:29)
>
>
> Review request for qpid.
>
>
> Summary
> -------
>
> This patch adds a new method to the qpid::messaging::Session class in the public API that allows all messages up to a certain point to be acknowledged.
>
>
> This addresses bug QPID-3200.
> https://issues.apache.org/jira/browse/QPID-3200
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/include/qpid/messaging/Session.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/AcceptTracker.cpp 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/IncomingMessages.cpp 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.h 1130102
> /trunk/qpid/cpp/src/qpid/client/amqp0_10/SessionImpl.cpp 1133822
> /trunk/qpid/cpp/src/tests/MessagingSessionTests.cpp 1130102
>
> Diff: https://reviews.apache.org/r/882/diff
>
>
> Testing
> -------
>
> All existing tests pass, new test added to cover the new method.
>
>
> Thanks,
>
> Gordon
>
>