You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "lifeSo (via GitHub)" <gi...@apache.org> on 2024/01/10 18:11:28 UTC
[PR] [#532] SpotBugs: Fix SC_START_IN_CTOR [incubator-uniffle]
lifeSo opened a new pull request, #1440:
URL: https://github.com/apache/incubator-uniffle/pull/1440
### What changes were proposed in this pull request?
Fix SC_START_IN_CTOR from SpotBugs suggestion.
### Why are the changes needed?
Fix SC_START_IN_CTOR from SpotBugs suggestion.
Fix: #532
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#532] SpotBugs: Fix SC_START_IN_CTOR [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1440:
URL: https://github.com/apache/incubator-uniffle/pull/1440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#532] SpotBugs: Fix SC_START_IN_CTOR [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1440:
URL: https://github.com/apache/incubator-uniffle/pull/1440#issuecomment-1885388626
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `10 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`5d027c0`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/5d027c0ccc4f1c24225e5639f0a44142d4b7b1ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.38% compared to head [(`f095b1f`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 54.42%.
| [Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...iffle/server/TopNShuffleDataSizeOfAppCalcTask.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9Ub3BOU2h1ZmZsZURhdGFTaXplT2ZBcHBDYWxjVGFzay5qYXZh) | 61.53% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1440 +/- ##
============================================
+ Coverage 53.38% 54.42% +1.04%
+ Complexity 2729 2356 -373
============================================
Files 422 365 -57
Lines 24046 16835 -7211
Branches 2051 1533 -518
============================================
- Hits 12836 9162 -3674
+ Misses 10412 7158 -3254
+ Partials 798 515 -283
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1440?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#532] SpotBugs: Fix SC_START_IN_CTOR [incubator-uniffle]
Posted by "lifeSo (via GitHub)" <gi...@apache.org>.
lifeSo commented on PR #1440:
URL: https://github.com/apache/incubator-uniffle/pull/1440#issuecomment-1912909386
https://github.com/apache/incubator-uniffle/issues/1439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#532] SpotBugs: Fix SC_START_IN_CTOR [incubator-uniffle]
Posted by "lifeSo (via GitHub)" <gi...@apache.org>.
lifeSo commented on PR #1440:
URL: https://github.com/apache/incubator-uniffle/pull/1440#issuecomment-1885476809
Fix SC_START_IN_CTOR error from SpotBugs suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org